Skip to content

fix bug: '--tag-width 0' does not remove tags - #125

Merged
JakeWharton merged 2 commits into
JakeWharton:masterfrom
vigilancer:master
Jan 30, 2016
Merged

JakeWharton merged 2 commits into
JakeWharton:masterfrom
vigilancer:master

Conversation

@vigilancer

Copy link
Copy Markdown
Contributor

reverse index is error-prone feature

@JakeWharton

Copy link
Copy Markdown
Owner

Not sure this is a bug so much as an abuse of a feature to create unintended behavior.

Comment thread pidcat.py Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag_width > 0 check should wrap this whole block including the divider space that's added below. Otherwise you get a needless leading space.

@vigilancer

Copy link
Copy Markdown
Contributor Author

$pidcat -w 0

ImageLoader  W  You set too large memory cache size (more than 16 Mb)
  W  discCache() and discCacheFileNameGenerator() calls overlap each other
@pbGlobalUtils  E  Need to migrate from version 0 to 121
@pbpb reader jni  I  JNI_OnLoad: started
  I  JNI_OnLoad: started
@pbPB READER APP  W  Need migration/initialization
@pbsync  I  Syncronization: device time/timezone were changed
  I  TimeService: starting time service
  E  initialization error, ignoring intent=Intent { cmp=com.obreey.reader/com.obreey.books.sync.TimeService }
  I  Syncronization: device time/timezone were changed
  I  TimeService: starting time service
art  I  System.exit called, status: -1
AndroidRuntime  I  VM exiting with result code -1, cleanup skipped.

Not sure if it is intended behaviour.

JakeWharton added a commit that referenced this pull request Jan 30, 2016
fix bug: '--tag-width 0' does not remove tags
@JakeWharton
JakeWharton merged commit f818e10 into JakeWharton:master Jan 30, 2016
@JakeWharton

Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants