Repository navigation
Conversation
screenFetch only matched a process named exactly 'kwin' (KDE 4 era). Modern KDE Plasma runs 'kwin_x11' or 'kwin_wayland', so WM detection returned 'Not Found' on current KDE. Add both names to the detection list (keeping 'kwin' for legacy) and let the detection block run on Wayland-only sessions via WAYLAND_DISPLAY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WM detection only matched a process named exactly
kwin(the KDE 4 /early-Plasma name). Modern KDE Plasma runs
kwin_x11on X11 andkwin_waylandon Wayland, so screenFetch reportedWM: Not Foundoncurrent KDE.
Fix
kwin_x11andkwin_waylandto thewmnameslist and map both tothe
KWinlabel (barekwinkept for older setups).detectwmsession guard from[[ -n $DISPLAY ]]to[[ -n $DISPLAY || -n $WAYLAND_DISPLAY ]]so detection isn't skipped onWayland-only sessions without XWayland.
Notes
kwin_wayland→kwin(and possiblykwin_x11→kwin_legacy): https://invent.kde.org/plasma/kwin/-/work_items/120.Not Foundnow also reachWM-theme detection.
Testing
Validated the matching logic for
kwin,kwin_x11, andkwin_wayland(all resolve to
KWin). I'm on Xfwm4/X11, so I verified the KWin paths byisolating the detection logic rather than a live KDE run.