Repository navigation
Conversation
Add optional native HTTPS without restricting runtime hybrid key-exchange policy. Default RST MISP clients to certificate verification and isolate cached resolvers by credentials and verification mode. Document the PQC transport review, deployment policy, and handshake verification.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API previously only served plaintext HTTP, while RST Cloud's optional connections back to MISP disabled certificate verification by default. The resolver cache could also reuse a client across API keys or after verification was enabled.
This adds optional native HTTPS and fixes the RST verification defaults. It includes a source-based TLS/protocol review and reproducible hybrid key-exchange verification instructions.
--tls-certfile/--tls-keyfileoptions for a TLS 1.3 API listener. Invalid or incomplete TLS configuration stops startup before listening; existing loopback HTTP deployments keep working. OpenAPI advertises HTTPS when enabled, and non-loopback HTTP binds produce a warning.PQC scope: this establishes hybrid TLS capability and a deployment path; it does not certify every module or connection as PQC compliant. A capable runtime and compatible peer are required. Default groups can still fall back to classical key exchange. Hybrid key exchange does not provide post-quantum certificate authentication, and the API still requires trusted-network access or an authenticated proxy.
Migration: RST deployments using an untrusted/private MISP certificate must install the correct CA trust or explicitly configure
misp_verifycert=false. Optional resolution/write-back retains its existing best-effort behavior on connection failure, without retrying unverified.Validation
X25519MLKEM768with certificate and hostname verification; a TLS 1.2 client was rejected.git diff --checkpassed.The full external-service suite and live provider negotiations were not run. MkDocs is unavailable in the review environment; the documentation build remains for CI.