Repository navigation
Improve Wikidata enrichment, use MISP standard output and fix SPARQL injection - #1117
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a2a7e3d9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Wikidata module interpolates untrusted text into a SPARQL query and returns only the first entity URI in the legacy response format. This change escapes query literals and returns bounded candidate matches as standard MISP annotation objects, with labels, descriptions and Wikidata links related to the source attribute.
Addresses the SPARQL injection described in #869, including quotes, backslashes and control characters. Language tags and numeric settings are validated before query construction.
to_ids=false, with correlation disabled for descriptive text.Compatibility: legacy top-level
textrequests remain accepted, but all responses now usemisp_standard(results.Attributeandresults.Object). Consumers of the previous results list must migrate.Validation:
pytest -q tests/test_wiki.py tests/test_duckduckgo_search.py tests/test_expansion_smoke.py tests/test_dns.py: 224 passed.tests/test_expansions.py::TestExpansions::test_wikidata: passed against the running MISP modules service and Wikidata.LIMIT 1, including no-item cases: passed. A live Wikidata lookup with a one-result limit also passed.git diff --check: passed.