Repository navigation
Add permission checks to ban-related menus for enhanced security - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a permissions system for menu access throughout the global ban menu system. Now, each menu checks if the player has the appropriate permission before opening, and displays an error message if access is denied. The permission required for each menu is determined based on the action type (ban, temp ban, IP ban, kick, etc.).
Permission enforcement for menu access:
requiredPermission()method to all menu classes (PaginatedScreen,BanListMenu,PunishmentMenu,PunishMenu,PunishReasonMenu,PunishDurationMenu,PunishConfirmationMenu), specifying the necessary permission for each menu. [1] [2] [3] [4] [5] [6] [7]open()methods in all menus to check permissions usingPermissionRegistry.checkPermission()before displaying the menu, sending a red error message if the user lacks permission. [1] [2] [3]Integration and code improvements:
Permission,PermissionRegistry, andChatFormattingwhere required. [1] [2] [3] [4] [5] [6] [7] [8]This change ensures that only authorized users can access sensitive ban-related menus, improving security and user feedback.