Repository navigation
Implement security logging for various events - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive security logging system to the Global Ban mod, allowing important administrative and player actions to be logged for audit and monitoring purposes. The changes add a configurable security log feature, ensure that key events (such as punishing/unpunishing players, configuration reloads, and login attempts) are logged, and provide structured log messages for each action. Additionally, the configuration now allows enabling or disabling security logging.
Security logging feature:
securityLoggingEnabledconfiguration option inServerConfig, defaulting to enabled, to control whether security logs are recorded. [1] [2]securityLog(String message)method inGlobalBanCommonto centralize security log creation, respecting the config flag.Security log integration for key events:
.logSecurity()on event objects, ensuring that punishments, unpunishments, and clear punishment actions are logged with detailed messages. [1] [2] [3] [4]Event and record enhancements for logging:
.logSecurity()andtoSecurityLogString()methods in event records (PunishPlayerEvent,UnPunishPlayerEvent,ClearPunishmentEvent,CanPlayerLogin.Post) to generate structured log messages for each event type. [1] [2] [3] [4] [5]Other improvements:
[API SYNC]prefix for clarity. [1] [2]These changes provide robust auditing capabilities, making it easier for server administrators to monitor important actions and improve overall security.