Repository navigation
Refactor permission checks in punishment commands for improved accuracy - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the punishment command logic to improve permission handling and error messaging. The main changes clarify permission checks when punishing players and enhance user feedback.
Permission and error handling improvements:
PunishCommands.java, when a player does not have permission to punish another player, a clear error message is now sent to the command issuer, indicating the lack of permission and specifying the target player (You do not have permission to punish this player: ...).ChatFormatting.REDfor styling, improving code clarity. [1] [2]Permission checking logic:
Helpers.java, the check for theBLOCK_PUNISHMENTS_PERMISSIONpermission now correctly evaluates the target profile's online player rather than the command source, ensuring that protected players cannot be punished even if the issuer has high permissions.