Repository navigation
fix(api): set name on ApiUnavailableError and ApiRequestError (Fixes #867) - #954
Open
Lion4467cat wants to merge 1 commit into
Open
Lion4467cat wants to merge 1 commit into
Lion4467cat wants to merge 1 commit into
Conversation
|
@Lion4467cat is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Lion4467cat
force-pushed
the
fix/issue-867-error-names
branch
from
November 14, 2026 10:40
bb7b78a to
f1cb095
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #867
What changed
this.name = "ApiUnavailableError"andthis.name = "ApiRequestError"in both error constructors insrc/lib/api.ts(matchingEnvValidationErrorinsrc/lib/env.ts).src/lib/api.test.tsverifying.name,instanceof, stack-trace class identification, and error metadata (status,retryAfter,code).src/lib/api.tsandsrc/lib/utils.tsso the test suite and linter execute cleanly.Why
this.name, bothApiUnavailableErrorandApiRequestErrorinheritedError.prototype.name("Error"), causingconsole.error, stack trace headers, and error-reporting grouping keys to lose the distinction between unreachable-backend fallbacks and rejected action mutations.How to test
npx jest src/lib/api.test.ts --no-coverage(6 passed, 6 total)npx eslint src/lib/api.ts src/lib/api.test.ts src/lib/utils.ts(0 errors, 0 warnings)