Repository navigation
fix(api): add uncached fetchBountyLive for client polling and claim race refresh (Fixes #863) - #956
Open
Lion4467cat wants to merge 1 commit into
Open
Lion4467cat wants to merge 1 commit into
Lion4467cat wants to merge 1 commit into
Conversation
|
@Lion4467cat is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
…ace refresh (Fixes MergeFi#863)
Lion4467cat
force-pushed
the
fix/issue-863-fetch-bounty-live
branch
from
November 14, 2026 10:41
436cb44 to
191e0d1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #863
What changed
fetchBountyinsrc/lib/api.tsinto an uncachedfetchBountyLive(id, fallback?)function for client-side callers andexport const fetchBounty = cache(fetchBountyLive)for React Server Components.src/hooks/bountyPoller.tsandsrc/hooks/useClaimRace.tsto callfetchBountyLive, and cachedPollerEntry.snapshotinbountyPoller.tsso React 19'suseSyncExternalStorereceives a referentially stable snapshot across renders.src/lib/api.test.tsand updatedsrc/hooks/useBountyStatus.test.tsxandsrc/hooks/useClaimRace.test.ts.Why
React.cache()is a Server Component request-memoization primitive; calling it inside the browser polling loop (bountyPoller) and post-409 claim race refresh (useClaimRace) memoized the initial snapshot instead of observing fresh backend state on subsequent ticks.How to test
npx jest src/lib/api.test.ts src/hooks/useBountyStatus.test.tsx src/hooks/useClaimRace.test.ts --no-coverage(3 suites passed, 18 tests passed)npx eslint src/lib/api.ts src/lib/api.test.ts src/hooks/bountyPoller.ts src/hooks/useBountyStatus.ts src/hooks/useBountyStatus.test.tsx src/hooks/useClaimRace.ts src/hooks/useClaimRace.test.ts(0 errors, 0 warnings)