Skip to content

Wallet doesn't zero private keys. #294

Open

Description

@kayabaNerve

I experimented a bit with this while working with the Wallet RPC; we can clear the HD Wallets, the HTTP request, and have the RPC route take in a password which is then by passed by pointer, cleared when it unlocks the wallet. The problem is the password remains in the parsed JSON.

I'm creating an issue instead of fixing this as part of the new RPC as I'm not sure how to handle this comprehensively thanks to the JSON, as well as due to the annoyances involved with it. We may end up with a security model of "the password is there to stop disk theft; not memory theft, though it may help with that". Even if we adopt such a policy, we should still zero when possible (as it would help somewhat, if not most of the way).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions