Repository navigation
Conversation
| if (typeof fetchRemote !== 'boolean' || fetchRemote) { | ||
| await runCommand('git', ['fetch', '--tags']); | ||
| } |
There was a problem hiding this comment.
Could we cover this with some tests?
There was a problem hiding this comment.
This entire module is currently untested, unfortunately...
There was a problem hiding this comment.
basic unit test for the new behavior has been added, alongside a new run option to facilitate testing.
e3c697b to
091dd8d
Compare
|
Coming back to this PR. I think this would be useful to have, although for an additional reason than originally proposed. It appears that both |
|
This library has now been migrated into the release-tools monorepo. This PR has been locked and this repo will be archived shortly. Going forward, releases of this library will only include changes made in the release-tools repo.
|
Currently, the
getMostRecentTagswill perform agit fetch --tags, failing if the remote fetching does.This adds a new option
fetchRemote(defaulttrue). Setting it tofalsedisables the remote-fetching.Motivation: Allow running https://github.com/MetaMask/create-release-branch/ in an unauthenticated context.