Repository navigation
test: run auth packages on Vitest - #10951
Merged
Merged
Conversation
cryptodev-2s
force-pushed
the
test/vitest-auth
branch
from
October 21, 2026 10:14
75b8a3f to
450cccb
Compare
cryptodev-2s
marked this pull request as ready for review
October 21, 2026 10:26
cryptodev-2s
temporarily deployed
to
default-branch
October 21, 2026 10:26 — with
GitHub Actions
Inactive
cryptodev-2s
enabled auto-merge
October 21, 2026 10:29
dovydas55
approved these changes
Oct 21, 2026
Prithpal-Sooriya
added a commit
that referenced
this pull request
Oct 26, 2026
…itest migration - Replace one `jest.spyOn` with `vi.spyOn` in the user-assets tests; main migrated this package from Jest to Vitest (#10951). - Update `oxlint-suppressions.json`: one additional `no-unsafe-assignment`/`no-unsafe-return` pair from the new `getUserAssets` method (same `fetchQuery` idiom as the existing getters) and one `vitest/no-conditional-in-test` suppression for the cache-invalidation table test, matching repo-wide norms.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
@metamask/authenticated-user-storageto Vitest.References
Checklist
no-changeloglabel.Note
Low Risk
Test-only migration with no changes to library source; risk is limited to CI/local test execution for this package.
Overview
Migrates
@metamask/authenticated-user-storagefrom Jest to Vitest as part of the repo-wide test-runner move for auth-related packages.The package drops
jest.config.cjsand addsvitest.config.tsmerged from the sharedvitest.config.packages.js, keeping 100% coverage thresholds on branches, functions, lines, and statements.package.jsontest scripts now invokevitest(including watch/verbose/clearCache), Jest-related devDependencies are removed, andvitestis added.Tests in
authenticated-user-storage.test.tsare updated to Vitest APIs (vi.spyOn,vi.fn,Mocktype).tsconfig.jsonno longer includes Jest types. Monorepo wiring removes the package fromPACKAGES_ON_JESTintest-runner-package-map.cjsand drops the obsolete Jest config entry fromoxlint-suppressions.json.No production/runtime code changes—test and tooling only.
Reviewed by Cursor Bugbot for commit 450cccb. Bugbot is set up for automated code reviews on this repo. Configure here.