Repository navigation
Conversation
Update @metamask/delegation-deployments to ^2.1.0 across packages to include contract deployments for Robinhood Chain (4663) and Arc networks. Fixes MetaMask#10667 Signed-off-by: Roxen-AS <akash.arjun12@gmail.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Summary
Bump
@metamask/delegation-deploymentsto^2.1.0across all consuming packages (@metamask/gator-permissions-controller,@metamask/money-account-mfa-whitelist,@metamask/money-account-upgrade-controller, and@metamask/subscription-controller).Problem
In
wallet_requestExecutionPermissionson Robinhood Chain (chain ID 4663), the permission request screen renders but fails on Grant with:This occurs because
@metamask/gator-permissions-controllerpreviously declared@metamask/delegation-deployments^1.4.0, which lacked deployment entries for chain 4663. Versions 2.0.0 and 2.1.0 include deployments for Robinhood Chain (4663) and Arc networks.Solution
@metamask/delegation-deploymentsfrom^1.4.0to^2.1.0across the 4 consuming packages and updatedyarn.lock.packages/gator-permissions-controller/src/decodePermission/enforcerAddresses.test.tsasserting that Robinhood Chain (4663) contracts resolve to valid enforcer addresses.References
Fixes #10667
Checklist
Note
Medium Risk
Touches delegation signing and permission decoding paths across Money Account and Gator packages; incorrect deployment addresses would break grants on affected chains, but the change is a targeted dependency bump with regression coverage for Robinhood.
Overview
Bumps
@metamask/delegation-deploymentsfrom^1.4.0to^2.1.0in gator-permissions-controller, money-account-mfa-whitelist, money-account-upgrade-controller, and subscription-controller, with matching yarn.lock and changelog entries.v2.x adds delegation framework deployment metadata for Robinhood Chain (4663) and Arc networks that was missing in 1.4.0. That gap caused
wallet_requestExecutionPermissionson Robinhood to fail on Grant with delegation signing errors when enforcer addresses could not be resolved for the chain.Adds a gator-permissions-controller integration test asserting chain 4663 maps to valid enforcer addresses via
toEnforcerAddressesByName.Reviewed by Cursor Bugbot for commit 79a7830. Bugbot is set up for automated code reviews on this repo. Configure here.