Repository navigation
Conversation
…d network fails keyring_getAccountBalances passes failOnNetworks for the networks of the requested assets. If a native or token-account fetch for one of them fails, SnapAssetsAdapter throws AccountAssetsFetchError instead of returning a partial or empty result, so the client flags the balance unavailable instead of keeping a stale one. Other callers keep the skip-and-report behaviour.
This was referenced Oct 26, 2026
fix(stellar): run account reads under the fetch policy and report stale balances as unavailable
#525
Closed
…-solana-fail-on-fetch-error Co-authored-by: Raul Velaz <rvelaz@users.noreply.github.com>
Co-authored-by: Raul Velaz <rvelaz@users.noreply.github.com>
Co-authored-by: Raul Velaz <rvelaz@users.noreply.github.com>
Co-authored-by: Raul Velaz <rvelaz@users.noreply.github.com>
Co-authored-by: Raul Velaz <rvelaz@users.noreply.github.com>
…rror Co-authored-by: Raul Velaz <rvelaz@users.noreply.github.com> # Conflicts: # packages/solana-wallet-snap/CHANGELOG.md
Co-authored-by: Raul Velaz <rvelaz@users.noreply.github.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@metamask/solana-wallet-snapExplanation
Bug
When Solana RPC fetches fail,
getAccountBalancescan return a partial/empty map so the wallet keeps showing a stale SOL balance with no error.How to reproduce
Expected: balance becomes unavailable with Retry.
Actual (before): stale SOL amount.
Without a browser:
Keyring.test.ts› partial fetch failure throws.Why
SnapAssetsAdapterusedPromise.allSettledand dropped failed networks; successful RPC mixed with failed ones looked like a “successful” balance read.Validation
Keyring,AssetsService,SnapAssetsAdapter,indexerror paths): pass on branch20a63837.Changelog
Unreleased → Fixed: fail
getAccountBalanceswhen a requested network’s RPC fails (#527).