Repository navigation
Add bounded preprocessing capacity and task identity - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When preprocessing runs ahead of execution, prepared jobs can accumulate in the queue. This PR adds an optional
max_prepared_taskssetting to cap the combined number of jobs being prepared and jobs ready for execution.ModelQ checks capacity and claims a job in a single Redis operation so concurrent preprocessors enforce the same limit. When capacity is full, jobs wait in the preprocessing queue until a slot opens. Jobs already executing are excluded from the count. Callers that omit the setting keep the existing behavior.
This PR also exposes
get_task_id()during preprocessing and execution. Applications can use it to associate prepared resources with the same queue task across both stages.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.