Repository navigation
restart fixes for two-stream - #1321
Merged
Merged
Conversation
…l value, this will be better for future implementations that have twilight or pre-dawn diffuse radiation scattering
Contributor
Author
|
Note: this branch merged in luh2_nocomp_merge-bcindex from #1226 |
Contributor
|
This should address ESCOMP/CTSM#2325, correct? |
…fusion of ground albedos and performing a solve at the same time as constructing scattering elements
Contributor
Author
|
yes, I'll link the fix on the ctsm side of the PR |
ckoven
reviewed
Mar 19, 2025
|
|
||
| ! if(isnan(r_diff_dn))then !RGK: NVHPC HAS A BUG IN THIS INTRINSIC (01-2024) | ||
| ! if(shr_infnan_isnan(r_diff_dn)) then !RGK: this statement simply didn't work | ||
| ! Dont trigger an endrun, we flag an error with r_diff_dn, |
Contributor
There was a problem hiding this comment.
@rgknox I'm looking at this code and just noticing that the comment here says not to trigger an endrun, but it still seems like it does end up with an endrun anyway?
Contributor
Author
There was a problem hiding this comment.
Will update comments in future pr since tests are complete
glemieux
self-requested a review
March 24, 2025 18:40
glemieux
approved these changes
Mar 26, 2025
glemieux
left a comment
Contributor
There was a problem hiding this comment.
This looks good. Very compact and atomic PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This set of changes, as well as changes to the host, enable restart tests to pass when two-stream radiation is active. Also, subtle updates were made to zenith angle handling, specifically zenith angle is passed at the site level and there is no need to pass in a zenith active flag. Some minor code clean up is also included.
Synchronize with CTSM #2949
Collaborators:
@ckoven
Expectation of Answer Changes:
This may change answers slightly, but should not have any meaningful science changes.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: