Skip to content

update hydraulic conductivity scaling model - #1565

Open
xuchongang wants to merge 5 commits into
NGEET:mainfrom
xuchongang:xuchongang/taper_update
Open

xuchongang wants to merge 5 commits into
NGEET:mainfrom
xuchongang:xuchongang/taper_update

Conversation

@xuchongang

@xuchongang xuchongang commented May 7, 2026 •

Copy link
Copy Markdown
Contributor

Taper improvement.pdf

This pull request update the petiole length parameter to match the scaling of conduit size from Olson 2020 (https://nph.onlinelibrary.wiley.com/doi/10.1111/nph.16961)

Description:

The original scaling model has a much larger scaling of conduit size compared to the data from Olson 2020. To resolve this issue, I have added a new taper function based on Olson 2020. Please see attached the derivation of the taper components. Our hydraulic model optimization showed that this version of the taper function should be much closer to observations. This could also resolve the issue of size distribution of water potential. By lowering the hydraulic conductivity for taller trees, it will give a higher water stress for larger size of tree and thus higher mortality.

Collaborators:

@bchristo

Expectation of Answer Changes:

By change this values, we will see more reasonable scaling and make the model easier to fit to observed sapflow.

Description of generative AI usage (as necessary)

No AI used.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • [ x] The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary
  • Describe use of generative AI (if necessary)

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

No need to change to the documentation.

Test Results:

See attached figures of scaling with the impact of change.

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

… to match the scaling for conduit width from Olson 2020
@ckoven

ckoven commented May 7, 2026

Copy link
Copy Markdown
Contributor

Thanks Chonggang and really interesting. Should this be in the parameter file, rather than hard-coded though?

@xuchongang

xuchongang commented May 7, 2026 via email

Copy link
Copy Markdown
Contributor Author

@glemieux glemieux assigned rgknox and unassigned rgknox May 7, 2026
@glemieux
glemieux requested a review from rgknox May 7, 2026 23:24
@xuchongang xuchongang changed the title update the petiole length parameter to match the scaling from Olson 2020 update hydraulic conductivity scaling model May 11, 2026
@xuchongang

Copy link
Copy Markdown
Contributor Author

@JunyanDing, @jennykowalcz , @yfang-pnnl , it would be great if you could review.

@rgknox, it would be great if you could do some test on the most recent version of FATES!

@jennykowalcz
jennykowalcz self-requested a review May 19, 2026 18:58
@rgknox

rgknox commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@xuchongang , I see you keep the old taper function by re-naming it to xylemtaper_Savage(). Did you want to keep that function around in case we re-implement it in the future? Its nice to get rid of unused code. Also, the hard-coded parameter is changed in that unused function, which I thought was unexpected, ie why change something that is not used.

@rgknox rgknox added software: not API changing Does not require a change to the HLM API parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters) testing: partial non-b4b Only specific test configurations have differences labels Aug 3, 2026
@jennykowalcz

Copy link
Copy Markdown
Contributor

@xuchongang , I see you keep the old taper function by re-naming it to xylemtaper_Savage(). Did you want to keep that function around in case we re-implement it in the future? Its nice to get rid of unused code. Also, the hard-coded parameter is changed in that unused function, which I thought was unexpected, ie why change something that is not used.

Would it make sense to keep the old version of the taper function and have a parameter or namelist switch to select the between the two?

@jennykowalcz jennykowalcz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the code change follows Chonggang's description of the improved taper function.

I compared this update to the current Hydro implementation within my setup for the "DroughtMIP" project (Lichstein et al., in prep). See attached PDF comparing biomass, LAI, and NPP at Tapajós National Forest (TNF) under a historical baseline climatology and two simulated dry/drought climatologies. Overall, the new taper function and parameterization results in higher sensitivity to climate variations and a more severe response to drying / drought. This is the expected direction of change. It is also answer-changing under the historical baseline scenario.

taper test.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters) science: hydrology software: not API changing Does not require a change to the HLM API testing: partial non-b4b Only specific test configurations have differences

Projects

Status: Finding Reviewers

Development

Successfully merging this pull request may close these issues.

5 participants