Skip to content

Use function to remove files from unit test build and remove more files - #1637

Open
billsacks wants to merge 1 commit into
NGEET:mainfrom
billsacks:reorganize_share_code
Open

billsacks wants to merge 1 commit into
NGEET:mainfrom
billsacks:reorganize_share_code

Conversation

@billsacks

Copy link
Copy Markdown
Member

Description:

(1) Use a utility function to remove files from the unit test build, avoiding repetitive boilerplate.

(2) Remove two additional share files from the unit test build because they have mpi dependencies. This will be needed following ESCOMP/EPS_Share#88 (share1.1.23), where these files are added to the list of share_sources because CTSM needs them. But it should be fine to bring this FATES change in before updating to that share code version.

Collaborators:

none

Expectation of Answer Changes:

none

Description of generative AI usage (as necessary)

none

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary
  • Describe use of generative AI (if necessary)

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

(1) Use a utility function to remove files from the unit test build,
    avoiding repetitive boilerplate.

(2) Remove two additional share files from the unit test build because
    they have mpi dependencies. This will be needed with an upcoming
    change to the share repository where these files are added to the
    list of share_sources because CTSM needs them.
@billsacks
billsacks requested a review from adrifoster November 10, 2026 20:20
@glemieux glemieux added type: refactor Restructures code without changing functionality type: testing Related to improvements in code testing (e.g. unit, regression, etc) labels Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: refactor Restructures code without changing functionality type: testing Related to improvements in code testing (e.g. unit, regression, etc)

Projects

Status: Finding Reviewers

Development

Successfully merging this pull request may close these issues.

2 participants