Repository navigation
feat(conversion): add a failure exit mode to HF/Megatron comparison - #6312
Conversation
|
@cuichenx Could you review the opt-in |
|
/ok to test 2153756 |
|
Automatic Claude reviews have been retired. To request a pull-request review, post a comment containing: Add |
Assisted-by: OpenAI Codex Signed-off-by: Yuchen Wang <93700456+yuchenwang3@users.noreply.github.com>
Assisted-by: OpenAI Codex Signed-off-by: Yuchen Wang <93700456+yuchenwang3@users.noreply.github.com>
7ebb0ad to
bb4937a
Compare
|
/ok to test bb4937a |
Mock scheduler selection instead of bypassing the Megatron forward helper. Drive the real inference wrapper, iterator, and forward-step callback with a single-microbatch test scheduler, then assert the scheduling and model input contracts. Preserve the existing offline AutoConfig fixture. Assisted-by: OpenAI Codex Signed-off-by: Yuchen Wang <eang333cms@gmail.com>
1bd9164 to
12a6ab7
Compare
|
The current head is |
|
/ok to test 12a6ab7 |
|
I'll watch this ready-to-merge PR and report substantive progress. Running on |
|
The model provider is unavailable. Work is paused and automatic retries have stopped. Send a new message or retry when the provider is available to resume. |
|
The watched PR is retired. |
|
I'll watch this ready-to-merge PR and report substantive progress. Running on |
Signed-off-by: Yuchen Wang <93700456+yuchenwang3@users.noreply.github.com>
Keep the pinned in-process restart guide and the current fault tolerance guide in all three resiliency documentation copies. Preserve all automatically merged changes. Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
|
/ok to test b5b514d |
|
/ok to test 307be90 |
|
/ok to test dd9aaef |
What does this PR do?
Add
--fail-on-mismatchto the HF/Megatron forward comparison. Today a different next token or cosine similarity below 0.99 is printed, but the command still exits successfully. The new flag makes those cases fail the command, so a validation job can use its exit status.Changelog
Validation
Local test command (isolates the CPU test file from GPU-dependent conftest imports):
GitHub Actions CI
External contributor; NVIDIA runner approval is needed for CI.
Before your PR is ready for review
Additional Information
Implementation and tests were written with OpenAI Codex.