Skip to content

[None][doc] Scope unit-test guidance and consolidate waive rules - #22427

Draft
chzblych wants to merge 2 commits into
NVIDIA:mainfrom
chzblych:docs/test-review-agent-guidance
Draft

chzblych wants to merge 2 commits into
NVIDIA:mainfrom
chzblych:docs/test-review-agent-guidance

Conversation

@chzblych

@chzblych chzblych commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Problem

Review feedback in #22261 asks contributors to justify unit-test coverage and CI placement, avoid compiling test helpers during test execution, and self-review new waivers. The CI overview also carries detailed waiver mechanics that belong beside the test lists.

Solution

  • Extend the existing tests/unittest/AGENTS.md with the regression/coverage/placement questions and build-stage preparation guidance.
  • Move the detailed waiver rules into a dedicated Waive list section in tests/integration/test_lists/AGENTS.md, with an explicit self-review requirement for every added or broadened waiver.
  • Distinguish tests retained for a fix from deliberately retired tests. Allow justified broad waivers for widespread failures and describe TOT merging for the PR's target branch, including release branches.
  • Keep the CI overview concise and link directly to that section.

Related: #21932; builds on #21934, #22124 and #22320. This changes documentation only.

Test Coverage

Validation

  • Repository pre-commit checks and DCO check passed.
  • Local Markdown links and heading anchors checked.
  • Isolated Sphinx/MyST build of the CI overview passed with warnings treated as errors; verified the rendered link includes #waive-list.
  • Waiver documentation checked against the existing parser, inner matcher and merge logic. No runtime behavior changes; GPU tests and a full documentation build were not run.

PR Checklist

  • Description, scope, coding/contribution guidance and DCO reviewed.
  • Relevant documentation updated and validated.
  • No API, dependency, test registration, waiver entry or ownership changes.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych chzblych changed the title [None][doc] Codify test review guidance and localize waive rules [None][doc] Scope unit-test guidance and consolidate waive rules Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant