Skip to content

fix: check autotune winner by timing - #1840

Open
Ninzore wants to merge 1 commit into
NVIDIA:mainfrom
Ninzore:fix/autotune-paired-timings
Open

Ninzore wants to merge 1 commit into
NVIDIA:mainfrom
Ninzore:fix/autotune-paired-timings

Conversation

@Ninzore

@Ninzore Ninzore commented Nov 19, 2026

Copy link
Copy Markdown

Summary

Fix a hardware-dependent assertion in the autotune integration test. A smaller input is not guaranteed to run faster, so validate the selected winner against the final paired measurements instead.

Changes

  • Compare the two finalists' median timings and check the winning configuration.
  • Preserve the first finalist on an exact tie.

Testing

Passed on L40;
Command, run from cutile-rs/:
CUDA_ASYNC_SPIN_BUDGET_US=20 cargo test --locked -p cutile --test autotune --features experimental-tune end_to_end_grid_tune_on_gpu -- --exact

Result:
test end_to_end_grid_tune_on_gpu ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out

  • just -f cuda-oxide/Justfile check passes — N/A: cuTile-only test change.
  • cargo oxide run <example> passes, or smoketest passes — N/A: no SIMT example changes.
  • New example added — N/A.

Checklist

  • All commits signed off (git commit -s).
  • All commits cryptographically signed and shown as Verified on GitHub (git commit -S).
  • SPDX headers on new source files — N/A: no new source files.

Questions about the review? Ping us in #contributors on Discord.

Signed-off-by: ruolingp <33434617+Ninzore@users.noreply.github.com>
@Ninzore
Ninzore requested a review from elibol as a code owner November 19, 2026 18:29
@copy-pr-bot

copy-pr-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant