Repository navigation
fix(secret-scan): avoid full-history checkout for filesystem scans - #28
Conversation
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
I asked codex about similar existing issues: I found no recorded rejection of making Pulse’s checkout shallow in the requested sources. In Then I searched CUDA Python issues only. Two relevant decisions surfaced:
That second decision concerns changing the published So the handoff still looks reasonable. The unresolved question for the shared-workflow maintainers is whether the original full-history setting reflects an intended scan requirement that wasn’t documented in these discussions. |
|
The one workflow failure looks like a flake, but I don't see a Rerun button. codex: The failed job runs the Pulse OSS vulnerability scanner. At The scanner returned exit code 1. The workflow captured that status, then correctly failed in Enforce scan result. |
Releases the two secret-scan changes that landed after v0.5.0: - the job rename to pulse-secret (#31) - the shallow checkout for the filesystem scan (#28). Minor rather than patch. Neither change touches the workflow_call interface, which by README's versioning rules would make this a patch, but the rename changes the downstream status-check name from `… / pulse` to `… / pulse-secret`. Also moves the shallow-checkout entry out of [0.5.0]. It was added by #28 after v0.5.0 was stamped, so that tag carries neither the entry nor the change, and the released notes claimed a fix the release did not contain.
— codex GPT-6 on behalf of Ralf —
Pulse's filesystem scan currently starts with
fetch-depth: 0, downloading every branch and tag's history. In NVIDIA/cuda-python, this fetched the largegh-pageshistory and took 315.6 seconds before the scan could start: https://github.com/NVIDIA/cuda-python/actions/runs/41166557387/job/124435280090. Related: NVIDIA/cuda-python#2197.Use a depth-one checkout and rename the misleading "full history" step. The scanner still runs the same
filesystem /repocommand with the same result filters, failure policy, credential handling, and SARIF publication. Document the existing filesystem scope in the workflow catalogue and record the fix in the changelog.Validation:
This remains a Draft PR so CI and review can be coordinated with the maintainers. No workflow interface, scanner mode, or enforcement-policy change is proposed.