Repository navigation
Remove @angular/http from the dependecies #1842
Description
Environment
- NativeScript-Angular: 8.0.0
- Angular: 8.0.0
Describe the bug
The current 8.0.0 version of the plugin has a dependency for the @angular/http which is deprecated and replaced by the @angular/common/http package.
Reacted by Ben Sjoberg, Stan, David Burke, Morten Sjøgren, Yahya Kacem, Tomas, Dmytro Gokun, Stefan Charsley, Marco Marques and xuhcc
Activity
charsleysa commentedon Jul 18, 2019
The entire NSHttp module should be removed since Angular 8 no longer even has an Http module (only HttpClient).
IMO nativescript-angular@8.0.0-8.0.2 should be unpublished and 8.0.3 published with this code removed as it should have never been released with an unsupported beta library as a dependency.
VladimirAmiorkov commentedon Jul 18, 2019
Hi @charsleysa ,
Have you experienced any issues related to the use of the @angular/http in the nativescript-angular@8.0.0-8.0.2 ? In all of our tests the latest "@angular/http": "8.0.0-beta.10" version is working correctly no matter that it is a beta version.
We are planning to remove this as soon as possible but if you feel like contributing to the project we welcome your PR and contribution. Thank you.
charsleysa commentedon Jul 18, 2019
Hi @VladimirAmiorkov
We are seeing compilation errors wherever we include the
nativescript-angularlibrary at the root (soimport { ... } from 'nativescript-angular'.This seems to be due to the NSHttp module being reference by the root
index.tsfile.I would be happy to contribute a PR, though this is more of a release issue as this code should have been removed before
nativescript-angular@8.0.0was published so removing it now would be deemed a breaking change triggering a major version bump (as per semver).My proposed solution effectively rolls in the breaking change into the
8.0release by unpublishing all prior8.0.xreleases and updating the changelog to note why.Thoughts?
VladimirAmiorkov commentedon Jul 18, 2019
Does your project have a dependency of
@angular/http? Unpublishing a version ofnativescript-angularis not an option because we do not see any issues of using the latest version of@angular/httpwhich was released specifically for Angular 8 during its beta. The reason for not removing it before our 8.0.0 release was that there was no mentioning from the Angular team that this package will not leave the beta stage and that decision was made behind closed doors and we were only made aware at the release day of Angular 8.0.0 at which point it was too late to remove it since we are committed to delivering day one support for major releases of Angular.I am asking you if you find any real issues with having
@angular/httpas a dependency in you project because in all of our tests there is not issues either at runtime and at compilation time of the {N} + Angular project that uses it.charsleysa commentedon Jul 18, 2019
Hi @VladimirAmiorkov
I can confirm that adding
@angular/http@8.0.0-beta.10to the dependencies allows the compilation to succeed and the app runs without any apparent issues. One thing to note is that the library seems to be included in the vendor bundle, which is less than desirable, but I think its impact on bundle size during a production build mostly reduced thanks to the angular/webpack optimizers.Thanks for the help.
VladimirAmiorkov commentedon Jul 18, 2019
Yes that is correct, webpack will tree share that dep from the bundle and it will not affect the size of the app. Also in NativeScript 6.0.0 webpack is executed in all builds by default so the tree sharking is also present for local development.
You are welcome. We are in the process of addressing this and migrating from this deprecated package or deprecating it so we can remove it safely in future version.
charsleysa commentedon Aug 30, 2019
@VladimirAmiorkov this can be closed now as it was solved by #1942
VladimirAmiorkov commentedon Aug 30, 2019
Resolved via #1942