Skip to content

ModalDialogService.showModal() doesn't show modal #273

Closed
#274
Closed
ModalDialogService.showModal() doesn't show modal#273
#274
Labels
bug
Milestone
NS 2.1

Description

@vakrilov
vakrilov
opened on Jun 6, 2016

Issue is reproduced here.

It happens when the following conditions are true:

  • showModal() is used in a component that has its change detection strategy set to onPush.
  • showModal() is called from an async callback (e.x. setTimeout())

Activity

  1. vakrilov commented on Jun 6, 2016

    @vakrilov
    vakrilov
    on Jun 6, 2016
    ContributorAuthor

    The problem is that when CD strategy is set onPush - we should trigger change detection manually when dynamically loading component (when loading the modal content).

  2. vakrilov
    added
    bug
    on Jun 6, 2016
  3. vakrilov
    added this to the NS 2.1 milestone on Jun 6, 2016
  4. vakrilov
    closed this as completedin #274on Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions