Repository navigation
perf: skip quoted attribute values in one step (long SVG path data 4-5x faster) - #919
Merged
amitguptagwl merged 1 commit intoNov 13, 2026
Conversation
amitguptagwl
merged commit Nov 13, 2026
339eaba
into
NaturalIntelligence:master
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Long attribute values are slow to parse.
tagExpWithClosingIndexwalks every character of a quoted value only to find its closing quote, andattrsRegxthen reads the value with a lazy[\s\S]*?up to a backreference, which V8 runs much slower than a negated character class. SVG is the common case: pathdattributes are often tens of KB.This PR jumps over a quoted value with
indexOfof its own quote character, and matches values with"([^"]*)"|'([^']*)'(the value now comes from group 3 or 4 through a smallattrValuehelper). Both stop at the first matching quote, as before, so the same strings reach entity decoding and the value processors. An unterminated quote still makestagExpWithClosingIndexreturnundefined, and tabs inside a value are still left alone.Same-process A/B on Node 24,
ignoreAttributes: false, median of 7 alternating rounds:The new spec covers long values that hold the other quote,
>,/>and tabs, and passes on master too. A differential fuzz against master (random documents with mixed and unterminated quotes, tabs, boolean and unquoted attributes, CRLF, 9 option sets, 54,000 comparisons) gave identical output and identical errors.Type