Repository navigation
retrackers: wait for the session copy rtorrent 0.16 writes later - #3528
Merged
Merged
Conversation
rtorrent 0.16 queues d.save_full_session for its session thread, so the inserted_new event that starts update.php can come before the session copy is on disk. A torrent added by upload has no tied file to fall back on, and got no tracker at all; one with a tied file had the trackers added to that file instead of the session copy. update.php now waits up to five seconds for the session copy before it looks for the torrent. On rtorrent 0.9.8 it is already there by then, so nothing waits there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rtorrent 0.16 queues d.save_full_session for its session thread, so the inserted_new event that starts update.php can come before the session copy is on disk. A torrent added by upload has no tied file to fall back on, and got no tracker at all; one with a tied file had the trackers added to that file instead of the session copy.
update.php now waits up to five seconds for the session copy before it looks for the torrent. On rtorrent 0.9.8 it is already there by then, so nothing waits there.