Repository navigation
Compare the zero-name torrents without their creation date - #3531
Merged
Merged
Conversation
Torrent stamps every torrent it builds with time() in creation date. TorrentZeroNameTest builds each one twice, from the relative and the absolute path, and compared the bytes, so it failed whenever the two builds fell in different seconds (php 7.4, run 42504155982). The bytes are now compared without that one key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TorrentZeroNameTest builds each torrent twice, from the relative and from the absolute path, and compared the
two results byte for byte. Torrent stamps every torrent it builds with time() in creation date, so the test
failed whenever the two builds fell in different seconds, as in run 42504155982 on PHP 7.4. The bytes are now
compared with that one key removed. Everything else in the metainfo, the info dictionary included, still has to
match.
With a one-second sleep between the two builds, master fails 8 checks and this change passes all 337. The full
suite passes on 7.4, 8.1, 8.5 and 32-bit.