Repository navigation
Conversation
Since 5.3.19 the redirect that answers an upload named an absolute URL built from the scheme PHP sees and the Host header. Behind a proxy that terminates TLS without sending X-Forwarded-Proto, that was http:// on an https:// page: the browser refused the upload frame's navigation, the frame could not be read, and a torrent that had been added was reported as "Failed to add torrent." (Novik#3533). A relative Location resolves against the URL the browser posted to, so it keeps the scheme, host and path prefix the browser used. It is now the target unless RU_PUBLIC_URL or $publicURL is configured, which still decides it. Requests::configuredPublicBaseURL() is split out of publicBaseURL() for that; the feeds links are unchanged.
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 5.3.19 the redirect that answers an upload named an absolute URL built from the scheme PHP sees and the Host header. Behind a proxy that terminates TLS without sending X-Forwarded-Proto, that was http:// on an https:// page: the browser refused the upload frame's navigation, the frame could not be read, and a torrent that had been added was reported as "Failed to add torrent." (#3533).
A relative Location resolves against the URL the browser posted to, so it keeps the scheme, host and path prefix the browser used. It is now the target unless RU_PUBLIC_URL or $publicURL is configured, which still decides it. Requests::configuredPublicBaseURL() is split out of publicBaseURL() for that; the feeds links are unchanged.