Repository navigation
[16.0][FIX] shopfloor_reception: prevent response validation error on lot data without name - #1245
Open
nicolas-delbovier-acsone wants to merge 1 commit into
Open
nicolas-delbovier-acsone wants to merge 1 commit into
nicolas-delbovier-acsone wants to merge 1 commit into
Conversation
…ata without name
When serializing a move line that has an expiration
date but no lot name, the response payload generates a lot dictionary missing
the required 'name' key (or an incomplete dictionary).
This fails Cerberus REST response validation ('name' is a required field)
and causes an HTTP 500 error.
Contributor
|
Hi @JuMiSanAr, @mmequignon, |
OCA-git-bot
added
series:16.0
mod:shopfloor_reception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error
Put an
expiration_dateon the selected move line (but nolot_idnorlot_name).Note
There is also this other PR that would solve the problem here: #1241
SystemError: Invalid Response {'data': [{'set_lot': [{'selected_move_line': [{0: [{'lot': [{'name': ['required field']}]}]}]}]}]}@jbaudoux