Skip to content

deploy/: check the downloaded binary, normalise CAMEX_POOL, a test, web_listen #205

Open

Description

@compot-dev

Follow-ups for deploy/ (b90753c, the camex server in Docker), found when checking it for #202. Not blocking 5.0.0; the base image (alpine:3.20 → 3.22) and the secrets in the container's log are fixed in #202 already.

  1. The binary is not checked. deploy/Dockerfile downloads camex-<arch>[-full] from the latest release with wget over HTTPS and runs it, with no checksum. GitHub gives the SHA256 of each release file (digest in the release's assets, gh release view latest --json assets); the Dockerfile could take it (or a CAMEX_SHA256 build argument) and check the download, as ci/build-musl.sh does for its toolchains.
  2. CAMEX_POOL must be a network address. entrypoint.sh puts the server at the pool's address + 1, so CAMEX_POOL=10.60.1.7/22 gives 10.60.1.8/22 instead of 10.60.0.1/22. install.sh --pool takes the network of any address in it; the entrypoint should do the same, or refuse such a value.
  3. No test. Nothing in CI builds deploy/ or starts it. A small e2e test: build the image (with CAMEX_RELEASE pointing at the binary just built), start it in a bridge network, check the files it makes (mode 0600), that the log has no network name or psk, and that a client joins with what the log says.
  4. The start page and nginx (Server: the start page and the device lookup served by camex itself (web_listen, nginx auth_request), no sync script #203). With network_mode: host, nginx on the host could reach camex's own lookup on 127.0.0.1. Once Server: the start page and the device lookup served by camex itself (web_listen, nginx auth_request), no sync script #203 is in, the first start could write web_listen=yes (behind a CAMEX_DOMAIN), and docs/install.md#docker show nginx in front of it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    deferredPostponed, not planned for nowenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions