Skip to content

5.1.0: build profiles, a client build without the server - #209

Merged
compot-dev merged 2 commits into
masterfrom
build-profiles
Nov 22, 2026
Merged

compot-dev merged 2 commits into
masterfrom
build-profiles

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

Build profiles (#204); version 5.1.0.

  • make PROFILE=client: a client without the server (CAMEX_SERVER=0: noserver.c in place of server.c and cpaceguard.c), with TAP networks and mesh. make alone is PROFILE=full (server is the same): everything, now with L2 and mesh; without L2 on Windows and macOS. A flag given on its own wins over its profile (PROFILE=client CAMEX_L2=0 CAMEX_MESH=0).
  • Without the server, --mode server and --format nginx-map / nginx-index end with an error that says why; --help shows no server options.
  • camex --version has a second line, features: client, server, l2, mesh.
  • Release: camex-<arch> is the full camex, camex-<arch>-full the same file until 6.0.0, new camex-arm-client and camex-mipsel-client; ci/build-musl.sh checks the client under qemu.
  • The Android library is the client profile (no server, no TAP, no mesh yet).
  • The state of mesh and of the LAN bridge in bss instead of initialised data: 45 KB less on ARM (full ~360 KB, client ~270 KB).
  • A build directory remembers its flags (.flags): another profile in the same BUILD_DIR rebuilds every object.
  • docs/build.md: the profile and flag tables; README (three languages), docs/networks.md.
  • Tests: docker/test-e2e-client-profile.sh (the client profile against a full server over UDP and TCP), a CI step for it; test-e2e-tap.sh builds its camex without L2 itself; test-e2e-mesh.sh and test-e2e-bridge.sh take CAMEX_BINARY when it is the full one.

Checked locally in the CI's images: make test, all 26 e2e tests of the workflow, the APK (testReleaseUnitTest lintDebug assembleRelease), Windows x86_64 and i686 under Wine, ci/build-musl.sh arm with qemu, builds of every profile and flag set on x86_64, arm and mipsel without warnings, .github/check-version.sh. Not checked locally: macOS (no image) and mipsel with the OpenWrt toolchain under qemu.

Closes #204.

- make PROFILE=client: CAMEX_SERVER=0 (noserver.c in place of server.c and
  cpaceguard.c), with TAP networks and mesh; make alone is PROFILE=full
  (server is the same), now with L2 and mesh, without L2 on Windows and
  macOS. A flag given on its own wins over its profile.
- Without the server: --mode server and --format nginx-map / nginx-index
  end with an error that says why; --help shows no server options.
- camex --version: a second line, features: client, server, l2, mesh.
- Release: camex-<arch> is the full camex, camex-<arch>-full the same file
  until 6.0.0, new camex-arm-client and camex-mipsel-client; build-musl.sh
  checks the client under qemu.
- Android library: the client profile (no server, no TAP, no mesh yet).
- mesh and bridge state in bss instead of initialised data: 45 KB less on
  ARM (full ~360 KB, client ~270 KB).
- A build directory remembers its flags (.flags): another profile in the
  same BUILD_DIR rebuilds every object.
- docker/test-e2e-client-profile.sh; test-e2e-tap.sh builds its camex
  without L2 itself; docs/build.md: the profile and flag tables.
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

PR Summary by Qodo

Add full and client build profiles for camex 5.1.0

✨ Enhancement ⚙️ Configuration changes 🧪 Tests 📝 Documentation 🕐 40+ Minutes

Grey Divider

AI Description

• Add a client-only build while making full functionality the default on supported platforms.
• Report compiled features and reject server-only operations in client builds.
• Publish ARM and MIPS client binaries, document build flags, and test client-to-server
 connectivity.
Merge Risk 🟡 Medium

Blast radius 🟢 Low 💥 1 capability

  • 1 affected end-to-end capability after fault-specific containment; implementation boundaries do not widen its functional scope.
  • All affected behaviors are compile-time feature selection and the artifacts it produces.
  • The mesh and bridge init changes are guarded by the same profile flags and are exercised in the client binary.
Behavioral complexity 🟡 Medium 🧩 Compatibility cases, Interacting branches

  • Before: two flags (L2, MESH) defaulted off.
  • After: PROFILE sets defaults, and individual flags override them.
  • The platform (mingw or Darwin) removes L2 from the profile.
  • CAMEX_SERVER swaps server.c for stubs.
  • A flags stamp triggers rebuilds.
  • New correctness condition: every profile and flag combination must compile and link, the stubs must match server.h, and the runtime guards (validate_config, control, mesh and bridge zero-init) must agree with the compiled-out features.
Potential damage 🟡 Medium 🩹 Recoverable

  • Failures would show up as build or link errors, or as binaries missing a feature (for example Android without server or mesh, or a wrong artifact name).
  • The runtime server refusal is guarded in validate_config.
  • Bad releases can be corrected by rebuilding and republishing.
  • Revert and rebuild.
  • There is no persistent state.
  • Devices that installed a bad binary need a re-download.
Assessed commit 0b91578
Diagram

graph TD
  P["Profiles and overrides"] --> M["Build rules"] --> D{"Server enabled?"}
  D -->|yes| S["Server sources"] --> B["camex binary"] --> R["Release assets"]
  D -->|no| N["Client stubs"] --> B
  B --> T["E2E checks"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Compile server call sites out entirely
  • ➕ Avoids maintaining placeholder server functions.
  • ➕ Makes server-free dependencies explicit at each call site.
  • ➖ Requires broader conditional changes across shared runtime code.
  • ➖ Increases regression risk for the full build.

Recommendation: Keep the interchangeable server implementation and stub for this release: it preserves the shared interface while removing server code from client binaries. Revisit conditional compilation if the stub interface becomes difficult to maintain.

Files changed (22) +645 / -89

Enhancement (6) +292 / -10
MakefileImplement profile-based source selection +49/-7

Implement profile-based source selection

• Defaults to the full profile, accepts per-feature overrides, and substitutes noserver.c for server sources in client builds. Tracks compilation flags in .flags so switching settings rebuilds objects.

src/Makefile

bridge.cMove bridge state into zero-initialized storage +6/-1

Move bridge state into zero-initialized storage

• Removes initialized socket descriptors and adds a readiness guard so closing a never-opened bridge cannot treat zero values as sockets.

src/bridge.c

control.cReject nginx formats in client-only builds +29/-0

Reject nginx formats in client-only builds

• Excludes server-only map and index helpers from client builds and returns an explanatory error for either format.

src/control.c

main.cReport features and guard server CLI behavior +26/-0

Report features and guard server CLI behavior

• Adds compiled features to --version, rejects server mode without server support, and hides server-only options from client-build help.

src/main.c

mesh.cMove mesh state into zero-initialized storage +3/-2

Move mesh state into zero-initialized storage

• Removes the static initializer and closes the mesh socket only while active, preserving safe shutdown behavior.

src/mesh.c

noserver.cProvide a linkable server interface without server code +179/-0

Provide a linkable server interface without server code

• Implements inert server symbols for client-only builds, allowing shared runtime code to link without server.c or cpaceguard.c.

src/noserver.c

Tests (4) +160 / -5
test-e2e-bridge.shReuse a feature-complete bridge test binary +7/-1

Reuse a feature-complete bridge test binary

• Detects L2 and mesh through --version and uses CAMEX_BINARY as the full binary when suitable, avoiding a redundant build.

docker/test-e2e-bridge.sh

test-e2e-client-profile.shExercise client-only builds against a full server +129/-0

Exercise client-only builds against a full server

• Checks reported features, server-only command rejection, and help output. Runs Docker connectivity tests in both directions over UDP and TCP.

docker/test-e2e-client-profile.sh

test-e2e-mesh.shReuse a feature-complete mesh test binary +7/-1

Reuse a feature-complete mesh test binary

• Uses CAMEX_BINARY as the full binary when its reported features include L2 and mesh; otherwise builds one.

docker/test-e2e-mesh.sh

test-e2e-tap.shBuild a separate no-L2 TAP test binary +17/-3

Build a separate no-L2 TAP test binary

• Reuses an L2-enabled default binary when available and builds a distinct binary without L2 or mesh for rejection checks.

docker/test-e2e-tap.sh

Documentation (6) +133 / -53
CHANGELOG.mdDocument the 5.1.0 release +21/-0

Document the 5.1.0 release

• Records build profiles, feature reporting, release names, Android behavior, size changes, and test coverage.

CHANGELOG.md

README.mdExplain build variants and release downloads +18/-11

Explain build variants and release downloads

• Describes full and client binaries and lists the new ARM/MIPS client downloads. Notes the temporary -full compatibility name.

README.md

README.ru.mdUpdate Russian build and release guidance +18/-11

Update Russian build and release guidance

• Describes the two builds, client downloads, and legacy full-binary name in the Russian README.

README.ru.md

README.zh-CN.mdUpdate Chinese build and release guidance +16/-11

Update Chinese build and release guidance

• Describes the two builds, client downloads, and legacy full-binary name in the Chinese README.

README.zh-CN.md

build.mdSpecify profile defaults and flag overrides +54/-15

Specify profile defaults and flag overrides

• Adds profile and flag tables, platform defaults, feature-reporting behavior, firmware build examples, and revised ARM binary sizes.

docs/build.md

networks.mdAlign network documentation with profile defaults +6/-5

Align network documentation with profile defaults

• Clarifies that TAP, bridging, and mesh are included by default in both profiles and shows how to omit them.

docs/networks.md

Other (6) +60 / -21
build.ymlTest and publish client-profile artifacts +15/-3

Test and publish client-profile artifacts

• Adds the client-profile E2E step, includes client binaries in artifact uploads and size reports, and packages ARM/MIPS client releases. The full binary retains its legacy -full release name.

.github/workflows/build.yml

MakefileForward profile and server overrides +3/-1

Forward profile and server overrides

• Passes PROFILE and CAMEX_SERVER, alongside existing feature overrides, to the source build.

Makefile

camex-sources.cmakeSelect client-only sources for Android +7/-2

Select client-only sources for Android

• Replaces server sources with noserver.c and exposes CAMEX_NO_SERVER as a compile definition. Android continues without TAP or mesh.

android/camex-sources.cmake

CMakeLists.txtApply Android client-profile definition +2/-1

Apply Android client-profile definition

• Passes the source list's CAMEX_DEFINITIONS to the shared-library target so its runtime behavior matches the selected sources.

android/tunnel/CMakeLists.txt

build-musl.shBuild static ARM and MIPS client releases +32/-13

Build static ARM and MIPS client releases

• Uses the default full build for both full release names and builds separate ARM/MIPS client binaries. QEMU checks client features and refusal of server mode.

ci/build-musl.sh

version.hSet version to 5.1.0 +1/-1

Set version to 5.1.0

• Changes the compiled camex version from 5.0.1 to 5.1.0.

src/version.h

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (4) 📘 Rule violations (0) 📎 Requirement gaps (5) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Client build still ships server modules 📎 Requirement gap ⚙ Maintainability
Description
The SRCS list in src/Makefile keeps nginxmap.c, tcpgate.c and slotidx.c for every profile,
so a CAMEX_SERVER=0 build still compiles them. The checklist excludes these files from a
server-free build, and the PR description only says noserver.c replaces server.c and
cpaceguard.c, while the Android list in android/camex-sources.cmake drops slotidx but keeps
the other two.
Code

src/Makefile[49]

+SRCS = main.c camex.c netw.c pake.c monocypher.c util.c log.c crypto.c noise.c keys.c session.c tun.c offload.c packet.c net.c proto.c config.c client.c slotidx.c control.c nginxmap.c tcpgate.c
Evidence
The new SRCS line still lists nginxmap.c, tcpgate.c and slotidx.c, and the CAMEX_SERVER=0
branch only adds noserver.c, so these server-side files are compiled into the client profile.

Server-free client build
src/Makefile[49-49]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
Issue description
The `SRCS` list in `src/Makefile` compiles `nginxmap.c`, `tcpgate.c` and `slotidx.c` in every profile, but the checklist requires a `CAMEX_SERVER=0` build to exclude them.
Fix Focus Areas
- src/Makefile[49-49]
- src/Makefile[85-89]
- android/camex-sources.cmake[11-17]
Recommended Fix
Move `nginxmap.c`, `tcpgate.c` and `slotidx.c` into the `CAMEX_SERVER=1` branch, unless the client is shown to need them. If it does, record why and align the Android list with the Makefile.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. Plain make now builds the full camex 📎 Requirement gap ≡ Correctness
Description
PROFILE ?= full turns on L2 and mesh for a default build, so PROFILE_L2 and PROFILE_MESH both
become 1 where the checklist requires the server default of 1,1,0,0. The PR text states this change
on purpose, but it still departs from the requirement that the default build stays unchanged.
Code

src/Makefile[58]

+PROFILE ?= full
Evidence
The new default PROFILE ?= full sets PROFILE_L2 = 1 and PROFILE_MESH = 1, which differs from
the required server default and changes what a plain make produces.

Build profiles and flag overrides
src/Makefile[52-66]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
Issue description
The checklist requires a plain `make` to keep the server-only (1,1,0,0) build, but `PROFILE ?= full` with L2 and mesh on changes the default.
Fix Focus Areas
- src/Makefile[58-58]
- src/Makefile[52-66]
- docs/build.md[17-19]
Recommended Fix
Either set the default to `PROFILE ?= server` with L2 and mesh off, or record in the checklist that this default change is accepted, so the decision is explicit.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


3. CI skips warnings-as-errors client build 📎 Requirement gap ☼ Reliability
Description
The workflow adds an e2e step for the client profile, but no step compiles PROFILE=client with
warnings treated as errors. The repository contains no -Werror, so a client-only warning would not
fail CI.
Code

.github/workflows/build.yml[R156-158]

+      - name: E2E test (the client profile, without the server, issue #204)
+        run: ./docker/test-e2e-client-profile.sh
+        if: matrix.target == 'x86_64'
Evidence
The added step runs the client interop test, but nothing in the diff adds a warnings-as-errors
client compile, and the Makefiles contain no -Werror.

Client CI coverage
.github/workflows/build.yml[156-158]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
Issue description
The checklist requires CI to build `PROFILE=client` with warnings as errors, but the workflow only runs the client e2e test.
Fix Focus Areas
- .github/workflows/build.yml[156-158]
- src/Makefile[1-40]
Recommended Fix
Add a CI step that runs `make -C src PROFILE=client` with `-Werror` added to the compile flags, using a fresh BUILD_DIR, so a client-only warning fails the build.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


View review recommended (4)
4. Docs omit the Keenetic client build 📎 Requirement gap ⚙ Maintainability
Description
docs/build.md names Keenetic as a firmware that runs camex as a client, but its build commands
cover only OpenIPC and OpenWrt. A Keenetic user therefore has no documented client build path.
Code

docs/build.md[R60-65]

+A firmware (OpenIPC, OpenWrt, Keenetic) that runs camex as a client builds the
+client profile with its own toolchain, and turns off what it does not use:
+
+```sh
+make CROSS_COMPILE=arm-openipc-linux-musleabi- LDLIBS=-static PROFILE=client
+make CROSS_COMPILE=mipsel-openwrt-linux-musl- PROFILE=client CAMEX_L2=0
Evidence
The firmware section names OpenIPC, OpenWrt and Keenetic, but the code block under it contains only
an ARM and a MIPS make command, with no Keenetic toolchain.

Profile and release documentation
docs/build.md[60-66]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
Issue description
The firmware section of `docs/build.md` names Keenetic but gives no client build command for it.
Fix Focus Areas
- docs/build.md[60-66]
Recommended Fix
Add a `make PROFILE=client` example with the Keenetic toolchain and any needed `CAMEX_L2` or `LDLIBS` settings, beside the OpenIPC and OpenWrt examples.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


5. Release guide omits client files 📎 Requirement gap ⚙ Maintainability
Description
The README release table gains camex-arm-client and camex-mipsel-client, but docs/releases.md
is not changed to say which profile each release file is. Readers of the release guide cannot tell
which file is the client build.
Code

README.md[R115-116]

+| `camex-arm-client`         | Linux 32-bit ARM, static (musl): a client only, without the server                     |
+| `camex-mipsel`             | Linux MIPS little-endian, static (musl, soft-float): Ingenic cameras, routers          |
Evidence
The README adds the new -client release files, while docs/releases.md exists and is absent from
the changed-file list, so its release-to-profile mapping was not updated.

Profile and release documentation
README.md[115-116]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
Issue description
`docs/releases.md` must identify the profile of each release file, but this PR adds `camex-arm-client` and `camex-mipsel-client` without updating it.
Fix Focus Areas
- docs/releases.md
- README.md[109-126]
Recommended Fix
Add the new client files and the profile of each release file (`camex-<arch>`, `camex-<arch>-full`, `-client`) to `docs/releases.md`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


6. Client binaries break network test servers 🐞 Bug ≡ Correctness
Description
The new feature check in test-e2e-mesh.sh accepts CAMEX_BINARY as the full binary when it has L2
and mesh, without checking for the server feature. If a caller supplies a client-profile binary, the
script copies it into the server container, where --mode server is rejected; the bridge and TAP
scripts use the same selection pattern.
Code

docker/test-e2e-mesh.sh[R56-58]

+if [ -z "$CAMEX_FULL_BINARY" ] &&
+   "$CAMEX_BINARY" --version 2>/dev/null | grep -q '^features:.* l2.* mesh'; then
+    CAMEX_FULL_BINARY=$CAMEX_BINARY
Evidence
The client profile enables L2 and mesh but disables the server. Each test's new check can therefore
select that client binary, and the tests subsequently launch a container with --mode server, which
the serverless validation rejects.

src/Makefile[54-88]
docker/test-e2e-mesh.sh[53-65]
docker/test-e2e-mesh.sh[95-101]
docker/test-e2e-bridge.sh[55-65]
docker/test-e2e-tap.sh[53-70]
src/main.c[582-588]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The network test scripts can mistake a client-profile binary for a full binary and then use it to start their test server.
## Fix Focus Areas
- docker/test-e2e-mesh.sh[55-62]
- docker/test-e2e-bridge.sh[55-62]
- docker/test-e2e-tap.sh[53-61]
## Recommended Fix
In each automatic full-binary selection check, require `--version` to report `server` as well as the network features that test needs. Otherwise, build a full server-capable binary.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


7. Client help still suggests server commands 🐞 Bug ≡ Correctness
Description
print_usage() ends its new server-option guard before the common options and examples, leaving
--server-key-file and two --mode server recipes visible. A user consulting --help in a
client-only build is shown commands that its server-mode validation will refuse.
Code

src/main.c[830]

+#endif
Evidence
The new conditional hides the dedicated server-options section, but the later unguarded help text
prints a server-only key option and server startup examples. The serverless build rejects those
examples at validation.

src/main.c[813-830]
src/main.c[883-920]
src/main.c[582-588]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Client-only help hides the server-options section but still displays a server-only key option and server startup examples.
## Fix Focus Areas
- src/main.c[830-830]
- src/main.c[883-921]
## Recommended Fix
Guard the server-only common option and server startup examples with `#ifndef CAMEX_NO_SERVER`, while retaining help for client features and utilities that work without the server.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Informational

8. Make's help still calls the default build the core 🐞 Bug ⚙ Maintainability
Description
make help still says make CAMEX_L2=1 CAMEX_MESH=1 - the full camex, but this PR made
PROFILE=full (with L2 and mesh) the default. It also never mentions PROFILE=client or
CAMEX_SERVER, so anyone reading make help thinks a plain make builds the core camex and never
finds the client profile.
Code

src/Makefile[58]

+PROFILE ?= full
Evidence
The new profile block makes full the default, with CAMEX_L2 and CAMEX_MESH set to 1. The help
target, which the PR did not touch, still describes L2 and mesh as opt-in flags.

src/Makefile[52-80]
src/Makefile[189-197]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`make help` in src/Makefile still says `make CAMEX_L2=1 CAMEX_MESH=1` builds the full camex. After #204 a plain `make` already builds the full camex, and the help does not mention `PROFILE=client`.
## Fix Focus Areas
- src/Makefile[189-197]
## Recommended Fix
Replace the `CAMEX_L2=1 CAMEX_MESH=1` help line with lines for `make` (the full camex, the default), `make PROFILE=client` (no server) and `make PROFILE=client CAMEX_L2=0 CAMEX_MESH=0` (the smallest client).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


9. Outside Android builds get a half-client 🐞 Bug ☼ Reliability
Description
camex-sources.cmake now swaps server.c/cpaceguard.c for noserver.c in CAMEX_SRCS, but the
matching CAMEX_NO_SERVER define only reaches a build that adds the new CAMEX_DEFINITIONS itself.
Apps that include this file for their own JNI (the documented use) and keep their old
target_compile_definitions build main.c and control.c with the server code still in. Those
builds link against stubs, so --mode server and the nginx formats fail with misleading errors
instead of the clear refusal.
Code

android/camex-sources.cmake[R16-19]

+        net proto config client noserver control nginxmap tcpgate netw pake offload)
   list(APPEND CAMEX_SRCS "${CAMEX_SRC_DIR}/${name}.c")
endforeach()
+set(CAMEX_DEFINITIONS CAMEX_NO_SERVER)
Evidence
Only android/tunnel/CMakeLists.txt was changed to apply CAMEX_DEFINITIONS. The refusal in
validate_config and the nginx guards in control.c depend on CAMEX_NO_SERVER. In noserver.c,
server_clients_init returns -1 and the status functions return NULL.

android/camex-sources.cmake[4-19]
android/tunnel/CMakeLists.txt[12-15]
src/main.c[582-589]
src/noserver.c[20-24]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
External CMake includers of camex-sources.cmake get noserver.c without the CAMEX_NO_SERVER define unless they add CAMEX_DEFINITIONS themselves.
## Fix Focus Areas
- android/camex-sources.cmake[16-19]
## Recommended Fix
After building CAMEX_SRCS, add `set_source_files_properties(${CAMEX_SRCS} PROPERTIES COMPILE_DEFINITIONS CAMEX_NO_SERVER)` so every includer gets the define automatically. Keep CAMEX_DEFINITIONS for backward compatibility, or add a CHANGELOG note telling integrators to apply it.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can route each severity your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@compot-dev

Copy link
Copy Markdown
Collaborator Author

On the Qodo review of 0b91578:

  • 1 (nginxmap.c, tcpgate.c, slotidx.c in a client build): not an issue. tcpgate.c is the client's (client.c calls it), slotidx.c holds config.c's indexes, and nginxmap.c has the name and domain checks config.c uses; with -ffunction-sections and --gc-sections its map and page formatters are not in a client binary (nothing references them there). The issue's list was a first estimate.
  • 2 (plain make is the full camex): on purpose, the owner's decision after Build profiles: a client build without the server (CAMEX_SERVER, PROFILE=client|server|full) #204 was opened; the PR text and docs/build.md say so.
  • 3, 4, 5, 6, 7, 8, 9: real; fixed in the next PR (5.2.0, with Server: the start page and the device lookup served by camex itself (web_listen, nginx auth_request), no sync script #203): a PROFILE=client build with -Werror in CI, Keenetic in docs/build.md, the client files in docs/releases.md, the e2e scripts take CAMEX_BINARY as the full one only when it has the server too, a client build's --help without server keys and examples, make help with the profiles, and noserver.c refuses to build without CAMEX_NO_SERVER (an app that takes camex-sources.cmake without CAMEX_DEFINITIONS gets a clear error, not a half-client).

@compot-dev
compot-dev merged commit b3a6489 into master Nov 22, 2026
18 checks passed
@compot-dev
compot-dev deleted the build-profiles branch November 22, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build profiles: a client build without the server (CAMEX_SERVER, PROFILE=client|server|full)

1 participant