Repository navigation
Recompile Java when build file is changed - #561
Merged
Merged
Conversation
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
TrevCraw
reviewed
Nov 2, 2026
…eatures Signed-off-by: Paul Gooderham <turkeyonmarblerye@gmail.com>
TrevCraw
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of code changes due to a small change in strategy.
When the build file changes the former strategy was just to trigger a recompilation of failed Java files. When the dependencies change correctness demands that all the Java files are recompiled. Therefore the three booleans that control recompilation are removed and we call the "trigger" methods instead.
The behaviour with regard to
recompileDependenciesdoes not affect build file changes but the Java compilation method uses this option to recompile dependencies. Thus we remove the check of this option when the build file changes.Also remove the
generateFeaturesparameter toupdateArtifactPaths().One TODO item remains on line 4368.
Related to OpenLiberty/ci.maven#2126