Repository navigation
Faster Download ZIPs: store compressed files, deflate text at level 1 - #185
Open
t0mdavid-m wants to merge 1 commit into
Open
t0mdavid-m wants to merge 1 commit into
t0mdavid-m wants to merge 1 commit into
Conversation
The Download buttons pack the ZIP when they are clicked. Parquet caches and gzipped files were deflated again at the default level, which took most of the time and saved almost nothing. They now go into the ZIP as they are, and text files (mzML, TSV, FASTA) are deflated at level 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepJR6i7XoU4V3HUarX
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
What it changes
The Download ZIP buttons (one run, and all runs on the Download page) pack the ZIP when the button is clicked, and the browser waits until that is done. All files were deflated at the default level, including the parquet caches and gzipped files of a run, which are compressed already: that took most of the time and saved almost nothing.
Now:
.pq,.parquet,.gz,.zip, ...) go into the ZIP as they are;Measured
All six example runs (211 MB), packed as the all-runs download does:
The ZIPs open with any unzip tool as before; nothing changes on screen, so there are no screenshots.
Tests
tests/test_result_download.pygains a test that a parquet file is stored and a TSV deflated, with both contents intact.python -m pytest tests/test_result_download.py: 7 passed.Generated by Claude Code