Repository navigation
feat(ha): support multiple OpenNebula VIPs - #325
cgroschupp wants to merge 4 commits into
Conversation
sk4zuzu
left a comment
There was a problem hiding this comment.
Hi @cgroschupp,
Thank you for your contribution.
I'd like to request a change before accepting this PR.
If I'm not wrong what you want to automate is the modification of certificates and more arguments passed to vip.sh. However it looks like the same code is repeated in several places. I think a cleaner approach would be to decide early what one_vip should be via set_fact in the opennebula.deploy.common role. The one_vip fact could be just extracted from one_vips and stored via set_fact, that way most of the code would stay without modification in the correct simple form. Then in only those two mentioned places you could provide a list of VIPs constructed from one_vips if present.
If you agree with these modifications please change your PR accordingly and I'll accept this contribution.
4a7048b to
3c57426
Compare
|
Thank you for the review. I agree that resolving the primary one_vip early in opennebula.deploy.common would avoid the repeated fallback logic and keep the existing code simpler. |
OpenNebula HA deployments currently support only one virtual IP. This change adds support for assigning multiple VIPs through the RAFT failover hooks.
one_vipsaccepts either full mappings:or scalar addresses with global defaults:
The first entry is used as the primary endpoint when
one_vipis undefined. Definingone_vipexplicitly continues to override the primary endpoint while all entries inone_vipsare managed by the failover hooks.Compatibility
Existing deployments using
one_vip,one_vip_ifandone_vip_cidrcontinue to work unchanged.