Skip to content

fix(google_chat): list recent messages, spaces and members past the first page - #22483

Open
pcbeingused333 wants to merge 2 commits into
PipedreamHQ:masterfrom
pcbeingused333:fix-google-chat-options-pagination
Open

pcbeingused333 wants to merge 2 commits into
PipedreamHQ:masterfrom
pcbeingused333:fix-google-chat-options-pagination

Conversation

@pcbeingused333

@pcbeingused333 pcbeingused333 commented Nov 10, 2026 •

Copy link
Copy Markdown

Summary

The spaceId, messageId and memberId prop definitions in google_chat.app.mjs ignored prevContext and dropped nextPageToken. Google Chat's spaces.messages.list returns 25 messages per page by default, so in the UI only the first page of messages (and of spaces/members) could be picked, with no way to load more. The component guidelines ask async options() over a paginated API to support prevContext.

Each options() now sends pageToken from prevContext and returns { options, context: { nextPageToken } }. The google_chat package version and the versions of the actions/sources that import the app file are bumped.

A small Node script that stubs listSpaces/listMessages/listMembers (first page returns nextPageToken) fails before the change (bare array returned, token dropped) and passes after.

Checklist

Versioning

  • All components updated in this PR had their version updated (0.0.1 for new ones)
  • The app updated in this PR had its package.json's version updated

New app

  • The app updated in this PR is already integrated

CodeRabbit review

  • I have addressed or acknowledged all of CodeRabbit's review comments

This pull request was prepared with the assistance of an AI coding agent (Claude); the change should be reviewed like any other contribution.

Summary by CodeRabbit

  • New Features
    • Google Chat space, message, and member selection lists now support pagination, allowing additional options to load when results span multiple pages. Space selections continue to show only spaces of type “SPACE.”
  • Updates
    • Updated the Google Chat component and action and event source versions.

The spaceId, messageId and memberId option loaders ignored prevContext and dropped nextPageToken, so only the first page (25 messages by default) could be selected. Return options plus a nextPageToken context and pass pageToken on the next call. Bump package version.

Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
Bump patch versions of actions and sources that import google_chat.app.mjs so the components check passes.

Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
@vercel

vercel Bot commented Nov 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
pipedream-docs-redirect-do-not-edit Ignored Ignored Nov 10, 2026 8:30pm UTC

Request Review

@pipedream-component-development

Copy link
Copy Markdown
Contributor

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development

Copy link
Copy Markdown
Contributor

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Google Chat spaceId, messageId, and memberId option loaders now pass pagination tokens to list requests and return response tokens in context. The package, action, and source versions are also incremented.

Changes: Google Chat updates

Layer / File(s) Summary
Option loader pagination
components/google_chat/google_chat.app.mjs
The spaceId, messageId, and memberId loaders pass nextPageToken to their list requests and return the response token in context with the mapped options. The spaceId loader continues to filter for spaces of type SPACE.
Action, source, and package versions
components/google_chat/actions/*, components/google_chat/sources/*, components/google_chat/package.json
The Google Chat action and source versions and the package version are incremented.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested labels: User submitted, javascript

Suggested reviewers: michelle0927, thebestmoshe

Merge Risk: Minimal · up to 900f7

The pagination and version updates have no established issue that should block merging after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the Google Chat pagination fix for messages, spaces, and members.
Description check Passed The description explains the pagination change and version updates, and it completes the summary and versioning checklist. The CodeRabbit review checkbox remains unchecked, but the PR objectives repor…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the pagination change and version updates, and it completes the summary and versioning checklist. The CodeRabbit review checkbox remains unchecked, but the PR objectives report no specific requested change for this PR.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 11 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between aee3a3e and 900f717.

Files selected for processing: 12

  • components/google_chat/actions/create-message/create-message.mjs
  • components/google_chat/actions/get-member/get-member.mjs
  • components/google_chat/actions/get-message/get-message.mjs
  • components/google_chat/actions/get-space/get-space.mjs
  • components/google_chat/actions/list-members/list-members.mjs
  • components/google_chat/actions/list-messages/list-messages.mjs
  • components/google_chat/actions/list-spaces/list-spaces.mjs
  • components/google_chat/google_chat.app.mjs
  • components/google_chat/package.json
  • components/google_chat/sources/new-command-used/new-command-used.mjs
  • components/google_chat/sources/new-mention-received/new-mention-received.mjs
  • components/google_chat/sources/new-message-in-space/new-message-in-space.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

User submitted Submitted by a user

Projects

Status: Ready for PR Review

Development

Successfully merging this pull request may close these issues.

3 participants