Repository navigation
fix(google_chat): list recent messages, spaces and members past the first page - #22483
pcbeingused333 wants to merge 2 commits into
Conversation
The spaceId, messageId and memberId option loaders ignored prevContext and dropped nextPageToken, so only the first page (25 messages by default) could be selected. Return options plus a nextPageToken context and pass pageToken on the next call. Bump package version. Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
Bump patch versions of actions and sources that import google_chat.app.mjs so the components check passes. Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Summary
The
spaceId,messageIdandmemberIdprop definitions ingoogle_chat.app.mjsignoredprevContextand droppednextPageToken. Google Chat'sspaces.messages.listreturns 25 messages per page by default, so in the UI only the first page of messages (and of spaces/members) could be picked, with no way to load more. The component guidelines askasync options()over a paginated API to supportprevContext.Each
options()now sendspageTokenfromprevContextand returns{ options, context: { nextPageToken } }. Thegoogle_chatpackage version and the versions of the actions/sources that import the app file are bumped.A small Node script that stubs
listSpaces/listMessages/listMembers(first page returnsnextPageToken) fails before the change (bare array returned, token dropped) and passes after.Checklist
Versioning
0.0.1for new ones)package.json's version updatedNew app
CodeRabbit review
This pull request was prepared with the assistance of an AI coding agent (Claude); the change should be reviewed like any other contribution.
Summary by CodeRabbit