Repository navigation
Missing Trade Encounters #1451
Description
The API is missing a lot of trade encounters, what I've noticed so far is:
All RBY trades are missing.
All GSC Trades are missing:
All RSE Trades are missing:
All FRLG Trades are missing:
All G4 Trades are missing in HGSS and DPPt:
All G5 Trades are missing in BW and B2W2:
All G6 Trades are missing in XY/ORAS:
Gen 7 is the only gen with encounters that actually has the NPC trades, and it has them for both LGPE and SM/USUM!
Obviously they're missing in gens 8/9 as well, but there's currently no encounter data at all for them yet in the API anyway.
In addition to this, as discussed in my PR for Pokemon XD: Gale of Darkness, I think we should be add a new Encounter_Condition in Encounter_Conditions.csv called Trade.
And then, when adding NPC-Trade encounters to the API, we should add an encounter condition for each one that says what Pokemon to trade for them, and what the NPCs name is if they're named. Let's use Mimien the Mr. Mime as an example:
- 108,15,trade-REYLEY-abra,0
This notes which NPC to trade with and which Pokemon to give them. We would have to go back and add the conditions for the gen 7 pokemon trades as well.
Lastly, I do think it's important to have this data in the API. Certain Pokemon are only catchable in games via trade from an NPC, such as Mr Mime, Farfech'd, and a few others.
Things I think this issue should not cover:
- Trading for a Pokemon with another real gameboy
That is a much bigger task, out of scope with the NPC-Trade encounter_method, and also solvable by the end user.
Currently I'm working on a website with a friend and we can have the site display trade or transfer from X game just by using logic to deduce if the Pokemon is in the selected game or not, and what is the nearest game you could receive it from, so I don't think it's necessary to include in the API at all.
As with any issue like this I bring up, I'm of course willing to do the work and write down all these encounters. I would probably do 1 PR per gen as to not make a massive PR with like 85 trade pokemon from 7 regions and 10 games.
I would start with gen 1 and work my way up, but if anyone is interested in doing any of these I'd ask you post here so we don't both do the same gen at once!
Activity
notblisy commentedon Mar 26, 2026
Okay, I just finished the data for the RBY trades. A things to note I discovered as I worked on this!
This means the level range is the "minimum" level the Pokemon you're trading over can be, to level 100.
What I ended up doing was looking for the lowest level a Pokemon could be in that game version, not accounting for trading to another game, but I accounted for what level a Pokemon evolves at.
I'm worried about overwhelming with encounter.csv changes and then having to change all the data anyway, so I'll put in a PR after #1446 and #1447 are committed.
notblisy commentedon Mar 27, 2026
Just finished up doing GSC Trade data. It'll also be separate from RBY, not gonna do 1 huge PR. RSE looks super small, but I'll also keep it separate from FRLG because those games have about the same amount of data as RBY, which wasn't tiny.
notblisy commentedon Mar 27, 2026
I just finished up doing Trades for RSE. I figured since I'm not doing PRs yet, I would still show my work to prove I'm actually doing what I'm saying.
Obviously parsing my work in google sheets is not easy but the organization should be apparent:
I'll continue to update this specific post with my google sheets until stuff is ready for PRs. Obviously numbers of encounters, slots, locations, location areas, etc are all in need of an update but sheets can do that automatically in a lot of ways for me.
notblisy commentedon Aug 14, 2026
Finished up FRLG here: #1638
The remaining games are done:
DPPT
HGSS
BW1
XY
ORAS
notblisy commentedon Aug 16, 2026
With that, everything is finished since someone already added BW2, and G7 was already done. Once #1638 is approved, I'll do all of gen 4 in one PR, then BW1, and then all of G6, and then I can move onto pokewalker.
Naramsim commentedon Aug 16, 2026
Hi @notblisy give me some time to come back from vacation and I'll address your issue and PR
notblisy commentedon Aug 16, 2026
No worries. I only have the FRLG PR up atm! Hope you had a good holiday.
jemarq04 commentedon Aug 17, 2026
@Naramsim I've just gotten back from my own travel, I'll take a look at the PR!