pokepy rewrite #64

Activity

1. Kronopt

   added

   question

   on Dec 5, 2020
2. Naramsim commented on Dec 6, 2020

   

   Naramsim

   on Dec 6, 2020

   Last edited by Naramsim

   Member

   More actions

   Hi @Kronopt,

   I think you can go ahead and try developing a prototype (if you have time), maybe preserving the same APIs.

   What do you think about https://github.com/PokeAPI/pokebase? Because if you wanna move towards the implementation made in that repository, you could just improve that one.

   PS: I also think that both the Python wrappers should be able to query PokeAPI's root endpoints such as https://pokeapi.co/api/v2/machine/?offset=0&limit=200000
3. Kronopt commented on Dec 6, 2020

   

   Kronopt

   on Dec 6, 2020

   ContributorAuthor

   More actions

   Thanks for the answer, @Naramsim!
   I'm going to create a new branch and start developing there, whenever I have the time 😄

   I thought about messing with pokebase, but both projects would require some major overhauls. And since I'm not that familiar with pokebase, going with pokepy was the easiest solution for me.

   As for the root endpoints,

   PS: I also think that both the Python wrappers should be able to query PokeAPI's root endpoints such as https://pokeapi.co/api/v2/machine/?offset=0&limit=200000

   That's what I meant with the "resource list method". It's on the TODO list

   🚀React with 🚀1Reacted by Alessandro Pezzè
4. Naramsim commented on Dec 6, 2020

   

   Naramsim

   on Dec 6, 2020

   Member

   More actions

   Alright then :)

   Go ahead whenever you want and take your time. See this as a learning experience.

   Also, try to keep the module's APIs closer as much as possible to the ones already present. So people using the module won't have to change much in their code. Anyways, with the new code, we could release a major version so it's fine if some methods change.

   👍React with 👍1Reacted by Kronopt
5. C-Garza commented on Dec 7, 2020

   

   C-Garza

   on Dec 7, 2020

   Last edited by C-Garza

   Member

   More actions

   The pokebase wrapper does support root endpoints from what I can see. If you use something like:

   poke_list = pb.pokemon("pokemon")
   print(poke_list.results)
   print(poke_list.results[0].url) ###For bulbasaur url
   

   then you can get access to the root endpoint. I noticed something though testing it out with your /machine root and noticed that it didn't work for it. It actually doesn't work for any root endpoints that have no name property for the objects. What I mean is, the root endpoint for /machine gives

   results: [
     0: {
       url: "https://pokeapi.co/api/v2/machine/1/"
     },
     ...
   ]
   

   but the /pokemon endpoint does have a name property:

   results: [
     0: {
       name: "bulbasaur",
       url: "https://pokeapi.co/api/v2/pokemon/1/"
     },
     ...
   ]
   

   Anyway, this is getting beyond the scope of this issue and I'll open an issue over there but I just wanted to say that pokebase does seem to have root endpoints.

   👍React with 👍2Reacted by Alessandro Pezzè and Kronopt
6. phalt commented on Dec 8, 2020

   

   phalt

   on Dec 8, 2020

   Member

   More actions

   Happy to drop Beckett, it was an experiment for me and nothing more.

   👍React with 👍1Reacted by Kronopt