Repository navigation
Bump test-only libraries and apply the open dependabot fixes - #1431
Conversation
Neither is compiled into a deployed contract: the optimized build's sources include no murky or solarray files. solady, solmate, OpenZeppelin, and seaport-sol stay pinned because the deployed SeaportValidator, SeaportNavigator, and PausableZone compile them in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
handlebars 4.7.10, pbkdf2 3.1.7, and brace-expansion 2.1.7, copied from #1425, #1423, and #1422. A full in-range yarn upgrade would pull transitive packages published in the last few days, which Socket blocks, and the Hardhat toolchain leaves the repo later in this series. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The lockfile is missing matching selectors and dependency entries for the Handlebars and PBKDF2 upgrades, forcing clean installs to resolve uncommitted dependencies and preventing reproducible installation.
No open issues 🎉
What changed in this PR
Updates development-tool dependencies to incorporate the Dependabot security fixes while preserving deployed contract bytecode.
Changes:
- Bumps Handlebars to 4.7.10, PBKDF2 to 3.1.7, and brace-expansion to 2.1.7.
- Updates the dependency requirements recorded for Handlebars and PBKDF2.
| File | Description |
|---|---|
yarn.lock |
Updates three dependency versions, integrity hashes, and associated dependency requirements. |
Review effort: Balanced
Copying only the three bumped packages left six of their dependency ranges unresolved (minimist, neo-async, ripemd160, safe-buffer, sha.js, to-buffer), so a clean install resolved them on the fly. yarn install now records them; every added version is over two weeks old. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Copilot's body-only finding was right, and it's fixed in 49aaec9. The copied lockfile entries for handlebars 4.7.10 and pbkdf2 3.1.7 declared six dependency ranges with no entry of their own ( |
|
Thanks @tomhirst. On your two notes from Slack: Extending It also wouldn't have caught the #1429 hook issue. The Dependabot. The handlebars, pbkdf2 and brace-expansion bumps are in this PR's lockfile, so they land with this PR whatever happens to the rest of the stack. #1433 then deletes |
Stacked on #1430. It retargets to
mainonce the earlier PRs merge.Bumps the dependencies that can move without touching deployed bytecode.
Deliberately not bumped
yarn upgradewould pull 16 transitive packages published in the last two weeks, which Socket blocks. The Hardhat toolchain leaves the repo as its tests move to Foundry, which removes most of the npm tree and its alerts.Verification
testprofile 484/484,referenceprofile 484/484.yarn build, thenyarn testwith 402 passing.yarn install --frozen-lockfileis clean.🤖 Generated with Claude Code