Repository navigation
Pass the stream's time base to bitstream filters - #2516
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pcm_rechunkreturns every packet with a pts ofNonewhen it runs throughBitStreamFilterContext, and so does anysettsexpression that usesTB, likepts=PTS+10/TB. Both read the filter's input time base, which bsf.h says the caller sets beforeav_bsf_init(). PyAV copies the stream's codec parameters across but never its time base, so the filter sees 0/0.On av 19.0.2 a 48 kHz WAV through
pcm_rechunk=nb_out_samples=1024comes out as[None, None, None, None], and as[0, 1024, 2048, 3072]with this change. I've left the output side alone, so a filter that changes the time base (settswithtime_base=) still doesn't pass it on toout_stream.