Repository navigation
fix(ci): restore a meaningful Windows merge gate - #14298
Conversation
Keep the known workspace baseline visible while making Windows installer/script coverage and hosted process checks authoritative again.
Keep the broader failing baselines visible while making the verified Windows installer and Hosted process contracts authoritative.
|
Windows validation status:
The blocking Windows coverage in this PR is therefore the installer/security suite plus the Hosted process suite. |
|
✅ Qwen Triage finished — CI landed green on ✅ Qwen Triage 已完成 —— |
|
Thanks for the PR! Template looks good ✓ — every required section is filled in, including the Risk & Scope tradeoff and the Chinese translation. Problem: observed, and I confirmed it independently rather than taking the description's word for it. Merge-queue run Direction: aligned — this is CI gate reliability, squarely infrastructure, and it touches no public contract. Worth noting the Hosted process suite still passed 9/9 inside that same failing job, so the blocking leg that matters is healthy; the fix is about unblocking the rest. Size: not applicable. Two files, +42/−5: Approach: the scope feels right and the mechanism is correct — splitting the Three questions, none of them blockers:
Risk: no elevated risk signals — neither changed file matches the revert-correlated high-risk paths. Two accuracy nits for whoever touches this next, both non-blocking: the meta-test is still named "preserves test failures in every wrapped OS job" though Windows no longer preserves them as failures, and Moving on to code review. 🔍 中文说明感谢贡献! 模板完整 ✓ —— 所有必填章节都写了,包括 Risk & Scope 的取舍说明和中文翻译。 问题: 已观测到,而且我没有只采信 PR 描述,是自己独立确认过的。merge queue 运行 方向: 对齐 —— 这是 CI 门禁可靠性问题,属于纯基础设施,不涉及任何公开契约。值得一提的是,在同一个失败的 job 里 Hosted process suite 依然 9/9 通过,说明真正关键的阻断项是健康的;这次修复解决的是其余部分被卡住的问题。 规模: 不适用。两个文件,+42/−5: 方案: 范围合理,机制正确 —— 拆开 三个问题,都不是阻断项:
风险: 无升级风险信号 —— 两个改动文件都不匹配与 revert 相关的高风险路径。 两个准确性小问题,供后续修改者参考,均非阻断:meta-test 的名字仍是"preserves test failures in every wrapped OS job",但 Windows 已经不再把失败保留为失败了; 进入代码审查 🔍 — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
Code reviewI wrote down my own approach before reading the diff, from just the title and the "Why it's needed" section: split the Windows step's The shell logic is correct. Two non-blocking observations:
I checked the new pin block resolves against the YAML as written: CI test evidenceFetched once from the head commit's check-runs via the API; no polling. I did not build or execute anything from this PR — the review is static. The important structural fact: What does carry signal here is the Ubuntu lane, because Final CI results for
One row per check name (latest run); skipped checks omitted; failures sort first. / 每个检查名一行(取最新一次运行),省略 skipped,失败项排在最前。 Not verified, and why: the new step's runtime behaviour on an actual Windows runner. The two sandboxed lanes can't close that gap — For what it's worth on the author's side (their claim, not evidence I reproduced): the PR reports the installer/security cases and the Hosted suite passing on a remote Windows host. That is the right thing to have checked, and it's consistent with what I found in the merge-queue log — the Hosted suite passed 9/9 inside the failing job — but I could not independently confirm the installer suite result, because Real-scenario testingN/A — CI-workflow change with no user-visible product surface; there is nothing to drive in a terminal. Per the review rules I also did not execute any PR-derived code. 中文说明代码审查在看 diff 之前,我只根据标题和"Why it's needed"先写下了自己的方案:把 Windows step 里的 shell 逻辑是正确的。 两点非阻断观察:
我核对过新增的断言块能对上实际 YAML: CI 测试证据通过 API 对 head commit 的 check-runs 一次性抓取,未轮询。我没有构建或执行本 PR 的任何代码——审查是静态的。 关键的结构性事实: 真正有信号的是 Ubuntu lane,因为 CI 表格见上方标记区域(英文部分),此处不重复。 未验证的部分及原因:新 step 在真实 Windows runner 上的运行时行为。两个沙箱 lane 都补不上这个缺口—— 关于作者侧的情况(这是作者的说法,不是我复现的证据):PR 称安装/安全用例与 Hosted 套件在远程 Windows 环境通过。这是该检查的地方,也与我在 merge queue 日志里看到的一致——Hosted suite 在那个失败 job 里 9/9 通过——但安装套件的结果我无法独立确认,因为在我能读到的任何 Windows CI 运行中, 真实场景测试N/A —— 纯 CI workflow 改动,没有面向用户的产品界面,终端里没有东西可驱动。按照审查规则,我也没有执行任何来自本 PR 的代码。 — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
|
Confidence: 4/5 — the mechanism is right and I verified the problem from real logs rather than the description; the nits below are all non-blocking. Stepping back: this is a small PR that fixes a failure mode I confirmed is real, and it fixes the mechanism rather than the symptom. The tempting version of this change is to wrap On maintenance: in six months I'd thank the author rather than curse them. The change adds no abstraction, no new script, and no configuration surface — it reorders three invocations that already existed and pins the new order in the meta-test that was already pinning the old one. That pin was updated in the same commit, which is the part most often forgotten when Everything is necessary for the stated goal — there's no drive-by refactor or formatting churn in here, and the diff is two files. My reservations, honestly stated, none of them reasons to hold the PR: The tradeoff the author already named in Risk & Scope is the real one. Windows workspace and script results stop gating, so a new Windows regression among the ~2,100 currently-passing files becomes a warning in a log nobody reads on a green run. That is a genuine loss of coverage bought to recover a lane that was 100% red and blind. I think it's the right call as a temporary state, and it's reversible CI config — but "advisory until their standing baseline failures are repaired" deserves a tracking issue, because advisory states have a way of becoming permanent. Second, the one suite that can now fail the whole queue is Third, and the reason I'm not approving in this run: the changed step has never executed anywhere I can observe. If a maintainer wants the runtime behaviour settled before it reaches the queue, a 中文说明Confidence: 4/5 —— 机制是对的,而且我是从真实日志里确认了问题存在,不是照抄 PR 描述;下面几点都是非阻断的。 退一步看:这是个小 PR,修的是我确认真实存在的失败模式,而且修的是机制而不是表象。这个改动最容易写成的样子,是把 关于可维护性:六个月后我会感谢作者,而不是骂他。这个改动没有引入抽象、没有新脚本、没有新的配置面——它只是重排了三条本就存在的调用,并在原本就钉住旧顺序的 meta-test 里钉住了新顺序。这个断言在同一个 commit 里就更新了,而这正是 所有改动都是达成目标所必需的——没有夹带顺手重构或格式化噪音,diff 就两个文件。 我的保留意见,如实说明,都不是拦下 PR 的理由: 作者在 Risk & Scope 里已经点明的取舍,才是真正的那个。Windows 的 workspace 与脚本结果不再作为门禁,所以在当前约 2100 个通过文件里出现新的 Windows 回归时,只会变成一条绿色运行中没人会去看的日志里的 warning。这是为恢复一个 100% 红且盲的 lane 而付出的真实覆盖损失。我认为作为临时状态这是对的取舍,而且是可逆的 CI 配置——但"在既有基线失败修好之前先降为 advisory"这句话值得开一个跟踪 issue,因为 advisory 状态往往会变成永久状态。 第二,现在唯一能让整个队列失败的套件是 第三,也是我在本次运行中不直接 approve 的原因:被改动的 step 在我能观察到的任何地方都还没有执行过。 如果维护者希望在进入队列前先把运行时行为定下来,对 Windows lane 触发一次 — Qwen Code · qwen3.8-max-2026-09-02 Reviewed at |
qwen-code-review-bot
left a comment
There was a problem hiding this comment.
LGTM, looks ready to ship — CI landed green after the review. ✅
wenshao
left a comment
There was a problem hiding this comment.
Reviewed at 0e75a801a92a08646811af63ec0b0c9b74fef907: no new blocking findings.
The split removes the workspace-to-script short circuit, captures each exit status immediately, and preserves the installer result through cleanup and diagnostics. The separate Hosted step remains blocking. I also checked the updated workflow contract and related runner/Hosted/sampler assertions; there are no existing inline review threads to reconcile.
Verification:
- Executed the exact changed shell block with controlled command stubs on macOS Bash: all 8 workspace/scripts/installer success–failure combinations passed. All three commands ran in order, warnings matched the first two results, and the final status always matched the installer result, including when cleanup/diagnostic stubs failed. This verifies shell control flow, not Windows platform behavior.
- Independently inspected the Windows dispatch job. Its checkout is this exact SHA and the job succeeded: the dedicated installer run recorded 102 passed / 40 skipped, Hosted recorded 9/9 passed, and both advisory warnings appeared. The installer skips include the existing Get-FileHash case requiring unavailable PowerShell 7 modules. The changed contract suite also passed (12 passed / 2 skipped). The overall dispatch was cancelled in other jobs; this is evidence for the successful Windows job specifically.
The acknowledged tradeoff remains: new failures in the broader Windows workspace/script suites are also advisory. I treat that as the explicit scope of this PR, not a newly discovered implementation defect; the existing follow-up recommendation to restore broader gating still applies.
中文说明
评审提交 0e75a801a92a08646811af63ec0b0c9b74fef907,未发现新增阻断问题。拆分命令消除了 workspace 失败导致脚本套件不执行的短路;退出码捕获、清理和诊断后的状态保留正确,独立的 Hosted 步骤仍能阻断。已核对变更后的契约测试及相关 runner、Hosted、采样断言,目前没有待核对的行内评审线程。
验证包括:在 macOS Bash 中对原始脚本使用受控命令替身,8 种成功/失败组合全部通过,安装套件的失败不会被前序测试、清理或诊断覆盖;这仅验证 shell 控制流。另独立读取了上述 Windows dispatch 日志,确认 checkout 为本次提交,Windows job 成功,安装套件 102 项通过/40 项跳过,Hosted 9/9 通过,两条 advisory warning 均出现,变更的契约测试为 12 项通过/2 项跳过。安装测试的跳过项包含因缺少 PowerShell 7 模块而未运行的 Get-FileHash 用例。整个 dispatch 在其他 job 上被取消,不能据此称整个运行全绿。
已知取舍仍是:更广泛的 Windows workspace/脚本套件中新出现的回归也只会告警。这是 PR 明确选择的范围,不作为新增实现缺陷重复报告;此前关于后续恢复更广门禁的建议仍适用。
qqqys
left a comment
There was a problem hiding this comment.
APPROVE at head 0e75a801a92a08646811af63ec0b0c9b74fef907 — no historical blocking issues exist on this PR, and an independent Critical-only scan of the diff found none.
1. Historical review state
The only prior review is qwen-code-review-bot APPROVED at this same head (a 63-byte stub). There are no CHANGES_REQUESTED reviews, no review ledger, and zero review threads. reviewDecision is REVIEW_REQUIRED. So there is nothing to re-verify — this is a first substantive pass.
2. The split is lossless: nothing that test:ci ran is dropped
This was the main risk in the change, so I checked it against package.json at this head rather than the PR description:
test:ci = npm run test:ci:workspaces && npm run test:scripts
test:ci:workspaces = cross-env NODE_OPTIONS="--max-old-space-size=3072" npm run test:ci --workspaces --if-present --
test:scripts = vitest run --config ./scripts/tests/vitest.config.ts
test:ci is exactly the two commands the Windows step now runs separately, and both are unchanged in package.json between main and this head. So the Windows lane still executes the identical set of suites — it only stops letting the first one's exit code decide whether the second runs.
That last part is the actual bug being fixed, and it means coverage increases: under &&, a workspace failure short-circuited before test:scripts, so the required Windows installer coverage never executed at all. Now test:scripts always runs, and scripts/tests/install-script.test.js is re-run afterwards as its own blocking gate:
npx vitest run scripts/tests/install-script.test.js --config scripts/tests/vitest.config.ts
INSTALLER_RC=$?Same config as test:scripts, and both scripts/tests/install-script.test.js and scripts/tests/vitest.config.ts exist at this head. So the installer test moves from "silently skipped whenever the workspace suite was red" to "always runs, always gates".
3. Shell control flow is correct
set +e precedes all three invocations; each exit code is captured on the line immediately following its command (WORKSPACE_RC, SCRIPTS_RC, INSTALLER_RC); set -e is restored before the cleanup; and the step ends on exit "$INSTALLER_RC". The advisory branches cannot mask the blocking one, because the two ::warning paths only echo and never exit or continue. The pkill/kill cleanup and the df//proc/meminfo diagnostics keep their || true guards, so re-enabling set -e cannot abort before exit. The diagnostic dump is now keyed on INSTALLER_RC instead of RC, which matches the value actually being returned.
4. The Linux and macOS gates are untouched
The single ci.yml hunk is at @@ -1928,13 +1928,23 @@, which falls inside the test_windows job (starts line 1768) and after test_macos (1662–1768) and test (367). Both other jobs keep npm run test:ci and exit "$RC".
The test change preserves that: test_windows was removed from the shared ['test', 'test_macos'] loop — whose asserted command list still contains npm run test:ci, RC=$? and exit "$RC" — and given its own ordered list. So the shared assertions still pin the two blocking OS lanes to the old behaviour, and a future edit that weakened them would still fail here.
The new Windows list is a genuine ordering assertion, not a presence check: it walks 15 exact command strings through indexOf and requires each to be strictly later than the previous, so it pins the advisory-before-blocking sequence and would catch a reordering that moved the installer run above set -e or dropped a ::warning branch.
Two details I confirmed rather than assumed. The outer let previous = -1; does not collide with the same declaration inside the for (const jobName of …) loop — that one is block-scoped to the loop body, so this is shadowing, not redeclaration, and Lint & Static passing at this head confirms ESLint accepts it. And there is no earlier set -e in the Windows step that would make indexOf('set -e') resolve to a position before INSTALLER_RC=$? and fail the ordering — the green Linux lane below is direct proof, since that assertion runs there.
5. Independent verification that the assertion matches the real workflow
Test (ubuntu-latest, Node 22.x) ran npm run test:ci at this exact head and passed:
run head=0e75a801a92a08646811af63ec0b0c9b74fef907 conclusion=success
Test (ubuntu-latest, Node 22.x) pass 31m57s
Lint & Static (ubuntu-latest, Node 22.x) pass 19m41s
Integration Tests (no-AK, No Sandbox) pass 12m9s
web-shell E2E Smoke (ubuntu-latest, Node 22.x) pass 24m52s
scripts/tests/no-ak-integration-ci.test.js is part of test:scripts, so the modified assertion executed on a blocking lane and passed. This matters because the test reads .github/workflows/ci.yml from the working tree — the new Windows assertions are validated by the Linux job even though no Windows job runs them.
6. Disclosed tradeoff, not a blocker
Windows workspace and full script-suite failures become advisory. That is a deliberate reduction of gate strength on one platform, it is stated in the PR description and in Risk & Scope, and it is not silent: both suites still execute in full, their output stays in the log, and each non-zero exit emits a ::warning annotation. Given the alternative was a lane where every queued change went red on inherited baseline failures — and where the genuinely required installer test never ran at all — this is a net gain in signal. The right follow-up is repairing those baselines so the two suites can block again; that is already scoped out here.
Also non-blocking: Test (windows-latest, Node 22.x) and Test (macos-latest, Node 22.x) are both skipping on this PR, so the changed shell step is not exercised by this PR's own CI run. Its behaviour is verified indirectly (§2 script equivalence, §5 the assertion that pins it) plus the author's stated manual Windows run. Worth a look at the first merge-queue run to confirm the advisory branches emit and the installer gate holds.
The failed checks at this head — review-pr, delay-automatic-review, fallback-comment — are review-bot infrastructure lanes, not build or test lanes, and are not attributable to this change.
|
Verdict: merge-ready — 68/68 scripted assertions passed, 0 failed. Verified head
中文摘要结论:merge-ready——68/68 条脚本化断言全部通过。验证期间 PR 已于 2026-10-16 10:35(北京时间)被合入(squash 提交
Central claim and A/B proofClaim under test (from the PR body): the Windows lane still runs the full workspace and script suites but reports their existing failures as warnings, while the Windows installer/security tests and the Hosted process suite remain the blocking merge gate. Method: the
33/33 scripted assertions passed across the 11 cells (exit codes, exact stub call sequences, warning counts and texts, diagnostics presence). The extracted step bodies are archived as Base defect mechanism, proven with the real artifact: Production corroboration (census over the failing merge-queue run Contract test (scripts/tests/no-ak-integration-ci.test.js)
The new blocking gate command, executed for realThe triage review noted it "could not independently confirm the installer suite result, because
Corrections to earlier review-round descriptionsNone required — the triage bot's static analysis was accurate on every point this round measured: the lane's Findings (all non-blocking)
Targeted gates
Not covered
MethodologyRound ran 2026-10-16 ~10:23–11:05 Beijing on macOS 26 (arm64), Node 24.18.1. Worktrees at |
Clears the "Check lint gate freshness" failure in Lint & Static: main moved eslint.config.js (28415dd, QwenLM#14277) and .github/workflows/ci.yml (c3012a5, QwenLM#14298) after this branch's baseline, so the lane was checking out a stale gate definition. Pure mechanical merge, no hand edits: the merged tree is byte-identical to `git merge-tree --write-tree` and the PR delta is unchanged (24 files, +1773/-51). Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> Patrol-Run: qwen-pr-conflict/jmvaik7ci93
|
Released in v0.25.3. |




What this PR does
The Windows lane still runs the full workspace and script suites and reports their existing failures as warnings, while the Windows installer/security tests and Hosted process suite remain blocking.
Why it's needed
Enabling the merge queue reactivated a Windows lane with accumulated baseline failures. Every queued change became red for unrelated failures, and the root
test:cichain stopped before reaching the Windows installer coverage when workspace tests failed.Reviewer Test Plan
How to verify
Confirm that workspace and full script failures remain visible as warnings, while a failure in the dedicated installer test or Hosted process suite still fails the Windows job.
Evidence (Before & After)
N/A — CI-only change.
Tested on
Environment (optional)
Remote Windows PowerShell environment plus local macOS worktree.
Risk & Scope
Linked Issues
N/A
中文说明
这个 PR 做了什么
Windows lane 仍会运行完整 workspace 与脚本套件,并将已有失败作为 warning 完整展示;Windows 安装/安全测试及 Hosted 进程套件继续作为阻断项。
为什么需要
启用 merge queue 后,长期未运行的 Windows lane 暴露了累积的基线失败,导致所有入队变更都因无关问题标红;同时根级
test:ci在 workspace 失败后会提前停止,实际要求的 Windows 安装测试反而没有执行。Reviewer 测试计划
如何验证
确认 workspace 与完整脚本套件失败时仍会输出 warning,而专门的安装测试或 Hosted 进程套件失败仍会使 Windows job 失败。
证据(Before & After)
N/A — 仅 CI 变更。
已测试环境
环境(可选)
远程 Windows PowerShell 环境与本地 macOS worktree。
风险与范围
关联 Issue
N/A