Skip to content

test(web-shell): follow the renamed workspace copy in two e2e specs - #15860

Merged
wenshao merged 1 commit into
mainfrom
test/web-shell-e2e-renamed-copy
Oct 29, 2026
Merged

wenshao merged 1 commit into
mainfrom
test/web-shell-e2e-renamed-copy

Conversation

@wenshao

@wenshao wenshao commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

What this PR does

Updates two web-shell smoke specs to the copy #15315 introduced:

  • web-shell.host-directory-picker.spec.ts looks for the dialog titled Add workspace, not Add Workspace.
  • web-shell.standalone.spec.ts clicks the sidebar section button Workspaces, not Project.

Why it's needed

#15315 renamed sidebar.addWorkspaceTitle to Add workspace and sidebar.project to Workspaces. #15296 and #15319 merged into main the same day with specs that still use the old names, and #15315 did not touch them. Since then web-shell E2E Smoke (ubuntu-latest, Node 22.x) fails on every PR with these two cases, whatever the PR changes:

1) web-shell.host-directory-picker.spec.ts:90 › allows real interaction with a host-owned directory browser outside WebShell
   waiting for locator('[data-web-shell-dialog-title="Add Workspace"]')
2) web-shell.standalone.spec.ts:197 › no-workspace sessions remain visible beside collapsed Workspaces and persist independently
   waiting for getByRole('complementary').getByRole('button', { name: 'Project', exact: true }).first()

The same pair fails on #15853, #15684, #15849 and the run for codex/issue-11484-target-version.

Reviewer Test Plan

How to verify

From packages/web-shell:

npx playwright test --config playwright.config.ts --project=chromium --retries=0 \
  client/e2e/web-shell.host-directory-picker.spec.ts client/e2e/web-shell.standalone.spec.ts

Evidence (Before & After)

Run Result
main at fa7421bdc1, the two cases 2 failed, with the errors above
This branch, both spec files in full 15 passed

I also searched the e2e specs for the other strings #15315 renamed. The remaining hits are a fixture's displayName: 'Project' and the managed Add Workspace dialog, whose managed.remoteWorkspaceAdd copy #15315 kept.

Tested on

OS Status
🍏 macOS ➖
🪟 Windows ➖
🐧 Linux ✅

Environment (optional)

Node 22.22.2, Playwright Chromium, Debian 13.

Risk & Scope

  • Main risk or tradeoff: none; test-only. The specs now match the strings the UI renders.
  • Not validated / out of scope: the full e2e suite. Only the two affected spec files were run.
  • Breaking changes / migration notes: none.

Linked Issues

Follows #15315, #15296 and #15319.

中文说明

这个 PR 做了什么

把两个 web-shell smoke 用例改成 #15315 引入的新文案:

  • web-shell.host-directory-picker.spec.ts 查找标题为 Add workspace 的对话框,而不是 Add Workspace。
  • web-shell.standalone.spec.ts 点击侧栏中名为 Workspaces 的分组按钮,而不是 Project。

为什么需要

#15315 把 sidebar.addWorkspaceTitle 改成了 Add workspace,把 sidebar.project 改成了 Workspaces。#15296 和 #15319 同一天合入 main,它们带来的用例仍然使用旧文案,#15315 也没有改到这两处。此后,无论 PR 改了什么,web-shell E2E Smoke (ubuntu-latest, Node 22.x) 都会在这两个用例上失败,错误见上方英文部分。

#15853、#15684、#15849 以及 codex/issue-11484-target-version 分支的运行,都是这两个用例失败。

评审者测试计划

如何验证

在 packages/web-shell 目录下运行上方英文部分给出的 npx playwright test 命令。

证据(前后对比)

运行 结果
main(fa7421bdc1)上的这两个用例 2 个失败,错误与上面相同
本分支,两个 spec 文件全部用例 15 个通过

我还在 e2e 用例里搜索了 #15315 改名的其他文案。剩下的命中只有两处:一个测试夹具里的 displayName: 'Project',以及 managed 的 Add Workspace 对话框,它用的 managed.remoteWorkspaceAdd 文案 #15315 没有改。

测试平台

只在 Linux 上运行过;macOS 和 Windows 未测。

环境(可选)

Node 22.22.2,Playwright Chromium,Debian 13。

风险与范围

  • 主要风险或权衡: 无,只改测试。用例现在与界面实际渲染的文案一致。
  • 未验证或不在范围内: 完整的 e2e 套件。只运行了受影响的两个 spec 文件。
  • 破坏性变更与迁移说明: 无。

关联 Issue

承接 #15315、#15296 和 #15319。

#15315 renamed the sidebar's "Project" section to "Workspaces" and the
Add Workspace dialog title to "Add workspace". #15296 and #15319 merged
alongside it with smoke specs that still look for the old names, so the
web-shell E2E Smoke lane now fails on every PR in
web-shell.host-directory-picker.spec.ts:90 and
web-shell.standalone.spec.ts:197.
@qwen-code-review-bot

qwen-code-review-bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Qwen Triage finished — view run. See the stage comments in this thread for the result.

✅ Qwen Triage 已完成 —— 查看运行。结果见本线程中的各阶段评论。

@yiliang114 yiliang114 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings — test-only copy fix with zero risk.

Two e2e selector strings updated to match the rename #15315 landed ("Add Workspace" → "Add workspace", "Project" → "Workspaces"). The diff is exactly what the PR body describes.

@qwen-code-review-bot

Copy link
Copy Markdown
Collaborator

Thanks for the PR!

Template looks good ✓

Problem: observed, and I checked it independently rather than taking the description's word for it. On main right now sidebar.addWorkspaceTitle is 'Add workspace' and sidebar.project is 'Workspaces' (packages/web-shell/client/i18n.tsx:2145 and :2121), while these two specs still look for Add Workspace and Project. #15684 — which touches none of this copy — has web-shell E2E Smoke (ubuntu-latest, Node 22.x) red on exactly the two waits quoted above, ending 2 failed / 409 passed (30.0m); #15849 is red on the same check. Real, queue-wide breakage, not theoretical hardening.

Direction: clearly aligned. A check that fails on every PR regardless of what the PR changes destroys the signal for everyone else, so this is worth more than the two lines cost. #15315 standardized the copy deliberately and updated a dozen e2e specs in the same change — it just never touched web-shell.host-directory-picker.spec.ts, and missed one call site in web-shell.standalone.spec.ts that #15296/#15319 had landed the same day. Following the copy is the right call; bending the copy back to satisfy the specs would not be.

Size: not applicable — no core paths. Both files are e2e specs, so production logic lines are 0 and the whole diff is 4 test lines.

Approach: scope is exactly right, and I could not make it smaller. I did verify the completeness claim instead of assuming it: after this change the only Add Workspace (capital W) left in the e2e tree is managed-ssh-workspace-registration.spec.ts:108, and that one is correct — that dialog renders managed.remoteWorkspaceAdd, defined as 'Add Workspace' in components/managed/managed-workspace-messages.ts:8, a separate catalogue #15315 never touched. The other Project hit is a fixture's displayName, and host-directory-picker.spec.ts:162 is a test title, not a locator. I also swept the rest of what #15315 renamed (New task, Recent sessions, Register, Rename Workspace, Remove Workspace, Collapse/Expand project) and found no stale locator left behind — consistent with the 409 cases that do pass.

Risk: no elevated risk signals. Stage 1e's high-risk path list excludes .spec. files, and neither changed file is on it.

Moving on to code review. 🔍

中文说明

感谢贡献!

模板完整 ✓

问题:是已观测到的 bug,我独立核实过,没有只采信 PR 描述。当前 main 上 sidebar.addWorkspaceTitle 是 'Add workspace',sidebar.project 是 'Workspaces'(packages/web-shell/client/i18n.tsx:2145 与 :2121),而这两个用例仍在找 Add Workspace 和 Project。#15684 完全没有改这些文案,它的 web-shell E2E Smoke (ubuntu-latest, Node 22.x) 正是在上述两个等待处失败,最终 2 failed / 409 passed (30.0m);#15849 同一检查也是红的。这是真实的、影响整个 PR 队列的故障,不是理论性加固。

方向:明确对齐。一个不论 PR 改了什么都会失败的检查,会让所有人的 CI 信号失效,所以它的价值远超这两行的成本。#15315 是有意统一文案的,同一次改动里也更新了十几个 e2e 用例——只是完全没碰 web-shell.host-directory-picker.spec.ts,并且漏掉了 web-shell.standalone.spec.ts 里由 #15296/#15319 同日合入的一处调用点。跟随文案是正确的选择;反过来为了迁就用例而改回文案则不对。

规模:不适用——未触及核心路径。两个文件都是 e2e 用例,生产代码行数为 0,整个 diff 是 4 行测试代码。

方案:范围恰当,我无法再把它缩小。我确实核实了"改动已完整"这一说法,而不是直接假设:本次改动之后,e2e 目录里唯一剩下的 Add Workspace(大写 W)是 managed-ssh-workspace-registration.spec.ts:108,而那一处是正确的——该对话框渲染的是 managed.remoteWorkspaceAdd,在 components/managed/managed-workspace-messages.ts:8 中定义为 'Add Workspace',属于 #15315 没有触及的另一套文案表。另一处 Project 是测试夹具的 displayName,host-directory-picker.spec.ts:162 则是用例标题,不是定位器。我还排查了 #15315 改名的其余文案(New task、Recent sessions、Register、Rename Workspace、Remove Workspace、Collapse/Expand project),没有发现遗漏的过期定位器——这与 409 个通过的用例一致。

风险:无升级风险信号。Stage 1e 的高风险路径清单会排除 .spec. 文件,两个改动文件都不在清单上。

进入代码审查 🔍

— Qwen Code · qwen3.8-max-2026-09-02

Reviewed at 7fb01980fc5a7bc00e8920ce533bf511afde9475 · re-run with @qwen-code /triage

@qwen-code-review-bot

Copy link
Copy Markdown
Collaborator

Code review

My independent proposal before reading the diff: change the two expected strings in the specs, not the copy in i18n.tsx — #15315's standardization was deliberate, so the specs are what drifted. The diff does exactly that, and nothing else. No critical blockers, no AGENTS.md violations, no over-abstraction, no drive-by edits.

The one thing worth real scrutiny was whether name: 'Workspaces' + .first() now resolves ambiguously, since the rename could have made the selector match a second element. t('sidebar.project') renders in two places: WebShellSidebar.tsx:7065, as SidebarSessionSurface's label, and :7260, as the projects header toggle. The surface only turns that label into a button with aria-label={label} in the collapsed-rail branch — the expanded sidebar takes the early return at :966 — so the two never coexist where this spec runs, and the spec's toHaveAttribute('aria-expanded', …) assertions pin it to the header toggle regardless (the collapsed trigger carries no aria-expanded). No new ambiguity.

Nice side effect: web-shell.host-directory-picker.spec.ts was already inconsistent with itself — line 75 clicks name: 'Add workspace' (lowercase) to open the very dialog whose title line 71 then waited for as "Add Workspace" (capital). The change makes the file agree with itself, and matches what the sibling web-shell.remote-workspace-add.spec.ts:132 has been using all along.

Non-blocking, and about the pattern rather than this diff: these specs assert on localized English copy, which is precisely how a 31-file copy change broke them silently even though it updated 12 e2e specs in the same commit. Stable selectors (data-testid, or the data-web-shell-* attributes the dialog already exposes) would make future copy edits non-breaking. That's a sweep across ~14 files and clearly out of scope for a CI-unblocking fix — worth its own issue if anyone wants it. Same coupling explains why the header toggle's count badge (aria-label={t('sidebar.workspaceCount', …)}) would defeat exact: true if a scenario ever had projectWorkspaces.length > 1; this one never does, so it is not a defect here.

Test evidence

This is an unattended CI run, so per the gate's rules I did not build or execute any PR-derived code — the evidence below is the PR's own CI read through the API, plus static reading of the tree in a worktree.

What I verified myself, not from the description:

  • Before state — confirmed from a real failing job log. web-shell E2E Smoke (ubuntu-latest, Node 22.x) on feat(managed-agent): enable external workspace execution #15684's head (ed44bd302e, job 123394314718, conclusion failure) ends 2 failed / 409 passed (30.0m), with the errors waiting for locator('[data-web-shell-dialog-title="Add Workspace"]') and waiting for getByRole('complementary').getByRole('button', { name: 'Project', exact: true }).first(). A PR with no stake in this copy fails on exactly the two locators this diff rewrites.
  • Expected strings — confirmed in the tree. i18n.tsx:2145 'Add workspace', :2121 'Workspaces'; DialogShell.tsx:229 writes the rendered title into data-web-shell-dialog-title, and AddWorkspaceDialog.tsx:962 defaults it to t('sidebar.addWorkspaceTitle'), so the attribute really does carry the lowercase string.

The after state is being produced right now by this PR's own smoke run on the reviewed commit — that check executes precisely these two spec files, so it settles the claim directly. Fetched once; no polling. The author's local "15 passed" is their own report on Linux and is not what I am relying on.

No sandboxed lane named here, deliberately: there is no production behaviour for @qwen-code /verify to A/B against the base build and no TUI surface for @qwen-code /tmux, and the one behavioural claim — that these two specs pass — is exactly what the pending smoke check substantiates.

Qwen Triage Finalize rewrites the region below once CI settles, and performs the deferred approval.

Check Status Conclusion
Capture web-shell visuals (ubuntu-latest, Node 22.x) queued pending
Integration Tests (no-AK, No Sandbox) in_progress pending
Lint & Static (ubuntu-latest, Node 22.x) in_progress pending
OpenTUI no-flicker gate in_progress pending
TUI parity snapshots (ink vs opentui) in_progress pending
Test (ubuntu-latest, Node 22.x) in_progress pending
review-pr in_progress pending
triage in_progress pending
web-shell E2E Smoke (ubuntu-latest, Node 22.x) in_progress pending
Check TUI impact completed success
Classify PR completed success
Managed Agent gate completed success
Select the Managed Agent tier completed success
assign completed success
authorize completed success
authorize completed success
delay-automatic-review completed success
label completed success
…and 16 skipped checks (macOS/Windows test, CLI integration, tmux-testing, verify, publish-*, precheck/resolve/review-config, SDK Java, ack-review-request) completed skipped

Reading of that signal: nothing is red on this commit so far. The nine checks that have settled are green (Check TUI impact, Classify PR, Managed Agent gate, Select the Managed Agent tier, assign, authorize ×2, delay-automatic-review, label), 16 are skipped by design for this PR type — macOS/Windows Test, CLI integration, tmux-testing, verify, the publish-* jobs, and the bot orchestration prechecks — and nine are still in flight or queued. The one that actually decides this PR, web-shell E2E Smoke (ubuntu-latest, Node 22.x), is in_progress. I did not wait on it and am not guessing its outcome.

中文说明

代码审查

在读 diff 之前我自己的方案是:改这两个用例里期望的字符串,而不是改 i18n.tsx 里的文案——#15315 的文案统一是有意为之,漂移的是用例。diff 正是这么做的,而且没有多做别的。没有阻断性问题,没有违反 AGENTS.md,没有过度抽象,没有夹带无关改动。

真正值得推敲的一点是:name: 'Workspaces' 加上 .first() 会不会因为改名而匹配到第二个元素。t('sidebar.project') 有两处渲染:WebShellSidebar.tsx:7065 作为 SidebarSessionSurface 的 label,以及 :7260 作为工作区分组的折叠按钮。前者只有在折叠态(rail)分支里才会把 label 渲染成带 aria-label={label} 的 button——展开态在 :966 就提前 return 了——所以在这个用例运行的场景下两者不会同时存在;而且用例的 toHaveAttribute('aria-expanded', …) 断言本身就把它锁定在分组按钮上(折叠态触发器没有 aria-expanded)。改名没有引入新的歧义。

一个附带的正面效果:web-shell.host-directory-picker.spec.ts 原本自相矛盾——第 75 行点击的是 name: 'Add workspace'(小写)来打开对话框,第 71 行却等待标题为 "Add Workspace"(大写)的同一个对话框。这次改动让文件内部一致了,也与同目录 web-shell.remote-workspace-add.spec.ts:132 一直在用的写法对齐。

非阻断,且针对的是模式而非本 diff:这些用例断言的是英文文案本身,这正是为什么一次涉及 31 个文件的文案改动会静默地弄坏它们——即便同一次提交已经更新了 12 个 e2e 用例。改用稳定的选择器(data-testid,或对话框已经暴露的 data-web-shell-* 属性)可以让今后的文案调整不再破坏测试。那是一次跨约 14 个文件的清理,显然超出这个"解阻 CI"改动的范围——如果有意做,值得单开 issue。同一处耦合也解释了分组按钮上的数量角标(aria-label={t('sidebar.workspaceCount', …)})在场景满足 projectWorkspaces.length > 1 时会让 exact: true 失配;本场景不会触发,所以在这里不算缺陷。

测试证据

这是无人值守的 CI 运行,因此按照门禁规则,我没有构建或执行任何来自本 PR 的代码——下面的证据来自通过 API 读取的本 PR 自身 CI,以及在 worktree 中对代码树的静态阅读。

我自己核实的部分(不来自 PR 描述):

  • 修复前状态——取自真实的失败 job 日志。 feat(managed-agent): enable external workspace execution #15684 的 head(ed44bd302e,job 123394314718,结论 failure)上的 web-shell E2E Smoke (ubuntu-latest, Node 22.x) 以 2 failed / 409 passed (30.0m) 结束,错误是 waiting for locator('[data-web-shell-dialog-title="Add Workspace"]') 和 waiting for getByRole('complementary').getByRole('button', { name: 'Project', exact: true }).first()。一个与这些文案毫无关系的 PR,恰好在本 diff 改写的两个定位器上失败。
  • 期望字符串——在代码树中核实。 i18n.tsx:2145 为 'Add workspace',:2121 为 'Workspaces';DialogShell.tsx:229 把渲染出的标题写入 data-web-shell-dialog-title,而 AddWorkspaceDialog.tsx:962 将其默认值设为 t('sidebar.addWorkspaceTitle'),所以该属性携带的确实是小写字符串。

修复后的状态正由本 PR 在所审 commit 上的 smoke 运行产出——该检查执行的正是这两个 spec 文件,因此它能直接验证这一结论。检查只拉取一次,未轮询。作者本地"15 passed"是其自述(Linux),我没有把它当作依据。

这里有意不指定沙箱验证通道:没有生产行为可供 @qwen-code /verify 与 base 构建做 A/B,也没有 TUI 界面可供 @qwen-code /tmux 驱动;唯一的行为性结论——这两个用例能通过——正是待完成 smoke 检查所验证的内容。

CI 信号解读:本 commit 上目前没有红灯。已完成的 9 个检查全部通过,16 个按此 PR 类型设计性跳过(macOS/Windows Test、CLI 集成、tmux-testing、verify、各 publish-* 以及机器人编排类前置检查),9 个仍在运行或排队。真正决定本 PR 的 web-shell E2E Smoke (ubuntu-latest, Node 22.x) 处于 in_progress。我没有等待它,也不猜测其结果。CI 落定后由 Qwen Triage Finalize 就地更新上方表格并执行延迟批准。

— Qwen Code · qwen3.8-max-2026-09-02

Reviewed at 7fb01980fc5a7bc00e8920ce533bf511afde9475 · re-run with @qwen-code /triage

@qwen-code-review-bot

Copy link
Copy Markdown
Collaborator

Confidence: 5/5 — clean at every stage; the only thing outstanding is procedural, that the check which decides it is still running.

Stepping back: this is two characters of intent — make the specs say what the UI says — and it is the smallest change that could possibly fix the problem. My independent proposal was identical, so there is no simpler path I found that the diff missed. The motivation is not "I think this string should differ"; it is "an entire CI check has been red on every PR for a day", which I confirmed from another PR's real job log rather than from the description.

The part I would normally worry about with a rename-following test fix is silent incompleteness — the author fixes the two cases they saw and leaves three more stale. I went looking for that and it is not there: the other capital-W Add Workspace in the e2e tree belongs to the managed catalogue that #15315 intentionally left alone, the other Project is a fixture field, and a sweep of the rest of #15315's renames turned up nothing stale. The 409 passing cases corroborate it. If I had to maintain this in six months I would thank the author — a red-on-everything check is the kind of thing that quietly teaches everyone to ignore CI.

Two honest notes, neither against this diff. First, the durability follow-up from Stage 2: asserting on localized copy is what let a 31-file change break these silently, and moving the affected specs to stable selectors is worth its own issue. Second, this only became possible because a copy change landed alongside two spec PRs on the same day without either noticing — a reminder that a rename touching UI strings wants a full e2e run, not just the unit suite, before it merges.

Verdict: approve. GUARD is ok (same-repository branch, not a fork refactor), Stage 0 raised no escalation, and I found no blocking issue. But three of this PR's own workflow runs are still in flight on the reviewed commit — Qwen Code CI, tui-parity, and Web-shell Visuals — including the web-shell E2E Smoke job that is the entire point of the change. Approving now would attest to a result that does not exist yet, so approval is deferred until CI lands green on 7fb01980fc5a7bc00e8920ce533bf511afde9475, recorded by the marker below. Qwen Triage Finalize posts the commit-pinned approval once every check completes green, and withholds it if anything lands red or the head moves.

中文说明

Confidence: 5/5 — 各阶段均无问题;唯一未完成的事项是流程性的,即决定性的检查仍在运行。

退一步看:这本质上只是"让用例说出界面实际显示的内容",而且是能修复该问题的最小改动。我独立想到的方案与之一致,所以不存在我发现了、而 diff 漏掉的更简路径。动机不是"我觉得这个字符串应该不一样",而是"整整一天里,每个 PR 的某项 CI 检查都是红的"——这一点我是从另一个 PR 的真实 job 日志中确认的,而不是采信描述。

这类"跟随改名"的测试修复,我通常会担心的问题是不完整的静默修复:作者修好了看到的两处,却留下另外三处过期。我专门找过,这里没有:e2e 目录中另一处大写 W 的 Add Workspace 属于 #15315 有意保留的 managed 文案表,另一处 Project 是夹具字段,对 #15315 其余改名项的排查也没有发现遗漏。409 个通过的用例印证了这一点。如果六个月后由我来维护,我会感谢作者——一项"逢 PR 必红"的检查,正是那种会悄悄教会所有人忽略 CI 的东西。

两点坦率说明,都不是针对本 diff。其一,Stage 2 提到的可持续性问题:断言本地化文案,正是一次 31 文件的改动能够静默弄坏这些用例的原因;把受影响的用例改为使用稳定选择器,值得单开 issue。其二,这件事之所以发生,是因为一次文案改动与两个用例 PR 同日合入而双方都没有察觉——这提醒我们:涉及 UI 字符串的改名,合入前需要跑完整的 e2e,而不只是单元测试套件。

结论:批准。GUARD 为 ok(同仓库分支,不是 fork 的 refactor),Stage 0 未触发升级,我也没有发现阻断性问题。但本 PR 自身有三个 workflow run 仍在所审 commit 上运行——Qwen Code CI、tui-parity、Web-shell Visuals——其中就包括这次改动的全部意义所在的 web-shell E2E Smoke。现在批准等于为一个尚不存在的结果背书,因此批准延迟至 CI 在 7fb01980fc5a7bc00e8920ce533bf511afde9475 上全绿,由下方标记记录。全部检查通过后,Qwen Triage Finalize 会提交与该 commit 绑定的批准;若有红灯或 head 发生变动,则不会批准。

— Qwen Code · qwen3.8-max-2026-09-02

Reviewed at 7fb01980fc5a7bc00e8920ce533bf511afde9475 · re-run with @qwen-code /triage

@qqqys qqqys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 7fb01980fc5a7bc00e8920ce533bf511afde9475. Approving: no blocking finding was ever filed on this PR, and the two changed selector strings match what production renders at this head.

The two strings are the current ones, not a guess

  • "Add Workspace" → "Add workspace" in the host-directory-picker spec's dialog() locator. packages/web-shell/client/components/dialogs/AddWorkspaceDialog.tsx carries the lowercase form on main, and the sibling spec packages/web-shell/client/e2e/web-shell.remote-workspace-add.spec.ts already selects [data-web-shell-dialog-title="Add workspace"]. So the attribute value this spec was matching no longer existed, and the change brings it in line with both the component and the spec beside it.
  • 'Project' → 'Workspaces' in the standalone spec's sidebar button lookup, keeping exact: true. The sidebar's collapsible section is the "Workspaces" header row (WebShellSidebar's own prop doc names it, and WorkspaceSection's header button carries aria-expanded with toggleExpanded), so the old label was the stale side of the same rename.

Why this cannot be a false green

For a test-only copy fix the one Critical shape worth checking is a gate that now passes without testing anything, and this change cannot produce one:

  • exact: true is preserved on both lookups, so nothing was widened into a substring match that could match loosely.
  • The dialog locator still keys on the data-web-shell-dialog-title attribute rather than on visible text, so it stays tied to the component's own contract.
  • A Playwright getByRole(..., { name }) that matches nothing times out, and one that matches the wrong button leads the collapse/persist assertions that follow it to fail. Both surface as a red spec, not a silent pass — so the failure mode of a wrong string here is loud.
  • The assertions themselves are untouched; only the two selector strings changed, one line each.

CI

No failing checks. 10 passed and 10 were still running at review time — among them web-shell E2E Smoke (ubuntu-latest, Node 22.x), the lane that actually executes these two specs, plus Test (ubuntu-latest, Node 22.x), the no-AK integration tests, TUI parity and the OpenTUI no-flicker gate. I did not wait for them. My approval rests on the rename being present in production source and on a mismatched selector failing loudly, so a red in that lane would mean the second string is wrong rather than that this change is unsafe — worth a glance before merge, since it is the one piece of evidence I could not read.

@wenshao
wenshao enabled auto-merge (squash) October 29, 2026 12:25
@wenshao
wenshao merged commit 4dc63d0 into main Oct 29, 2026
73 of 76 checks passed
doudouOUC added a commit that referenced this pull request Oct 29, 2026
Reject malformed transcript coverage before bootstrap can spin. Type the
Managed smoke response and backport the two exact selector corrections
from 4dc63d0 (#15860).

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
yiliang114 added a commit that referenced this pull request Oct 29, 2026
Also carry the two smoke selector corrections already landed in #15860 (4dc63d0).

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
2SinceJuly added a commit to 2SinceJuly/qwen-code that referenced this pull request Oct 29, 2026
The branch predated QwenLM#15860, so the host-directory-picker and standalone E2E
specs still waited on the old "Add Workspace" dialog title and timed out.
Merging origin/main (24 commits) restores the current baseline.
callmeYe added a commit that referenced this pull request Oct 30, 2026
@wenshao
wenshao deleted the test/web-shell-e2e-renamed-copy branch October 30, 2026 19:43
@qwen-code-review-bot

Copy link
Copy Markdown
Collaborator

Released in v0.26.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants