Repository navigation
4.x: Add Streamable just overloads for 2-10 items - #8395
Merged
Merged
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.801 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.802 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8395 +/- ##
============================================
+ Coverage 98.58% 98.63% +0.04%
- Complexity 7169 7178 +9
============================================
Files 826 826
Lines 50972 51035 +63
Branches 6944 6944
============================================
+ Hits 50251 50336 +85
+ Misses 482 473 -9
+ Partials 239 226 -13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akarnokd
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #8299.
Summary
Add the
Streamable.justoverloads for 2 through 10 items, matching the correspondingFlowableAPI surface.Each overload:
@NonNull;Objects.requireNonNull;@throws NullPointerExceptionJavadoc, as required byCheckParamValidationNamingTest;fromArrayimplementation, preserving item order and completion behavior.Tests
Added focused coverage in
StreamableJustTestfor:Test-first evidence: before adding the overloads,
compileTestJavafailed with 18 errors covering the new normal-output and null-rejection calls.After the implementation and Javadoc corrections:
Both commands pass on Zulu JDK 26. The selected tests report 12 tests, 0 failures/errors, and 2 existing skips.
A full
gradle testrun after the corrections completed 14,334 tests with 918 skips and 5 failures in existingFlowableGroupByTest(4) andFlowableConcatTest(1), including timeouts and termination races outside this PR's changed Streamable code. The targeted Streamable and parameter-validation tests pass; no full-suite green result is claimed.AI disclosure: Kimi Code assisted with checking the API checklist, implementing the overloads, writing and running the tests, and preparing this PR description. The failing-before compilation evidence, parameter-validation correction, final test results, and final two-file diff were checked.
CI result for d57b78d
Validation, the default build, JDK 28, and the security scan pass. The JDK 27 job reports 14,334 tests completed with 918 skips and one failure:
FlowableWindowWithTimeTest.overlapBackpressure2. No Streamable test failed, and the failing Flowable timing test is outside the two changed files. No unrelated source changes were made to address it.