Repository navigation
Conversation
…ge, instead of being written as silence
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audio writers coerce NaN and Inf to zero (
audio-io.h). When the DiT or the VAE produces values that are not numbers, the track therefore comes out as silence: the job is reported done, nothing is logged, and a client only sees a silent file. A studio that checks its output reports "silence" with no stage to look at.[DiT-Generate] ERROR: N of M latent values are not finite (NaN or Inf).[VAE-Decode BatchN] ERROR: …line, and the job fails (ops_vae_decodereturns -1, and the server frees the other tracks as it does on any failure).Checked on a CPU build. A synth request with
latent_rescale: 1e30(finite latents, the VAE overflows) used to give a silent track. It now endsfailedwith[VAE-Decode Batch0] ERROR: 921600 of 921600 samples are not finite (NaN or Inf). Normal 10-second jobs on CUDA and CPU still finish with audio.