Repository navigation
Fix dead Shopify CLI local development link in README - #2102
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
The "localhost development" link points to shopify.dev/docs/apps/build/cli-for-apps/development, which now returns 404. Point it at the "Test apps locally" page instead.
Author
|
I have signed the CLA! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
In the README setup steps, the sentence "With the Shopify CLI you can use localhost development to run your app." links to
https://shopify.dev/docs/apps/build/cli-for-apps/development, which now returns 404.This PR points the link at
https://shopify.dev/docs/apps/build/cli-for-apps/test-apps-locally(page title "Test apps locally"; returns 200 directly, no redirect), which is the current Shopify CLI page about running an app locally.I used an AI assistant to find this broken link; the old and new URLs were checked with curl.
Reviewer's guide to testing
Open both URLs: the old one is a 404, the new one is the local development guide.
Things to focus on
README.md: one link.Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact users (not needed: README link only)README.md, if appropriate./docs, if necessary (not needed)