Skip to content

Fix dead Shopify CLI local development link in README - #2102

Open
farisbasha wants to merge 1 commit into
Shopify:mainfrom
farisbasha:docs-readme-cli-local-dev-link
Open

farisbasha wants to merge 1 commit into
Shopify:mainfrom
farisbasha:docs-readme-cli-local-dev-link

Conversation

@farisbasha

Copy link
Copy Markdown

What this PR does

In the README setup steps, the sentence "With the Shopify CLI you can use localhost development to run your app." links to https://shopify.dev/docs/apps/build/cli-for-apps/development, which now returns 404.

This PR points the link at https://shopify.dev/docs/apps/build/cli-for-apps/test-apps-locally (page title "Test apps locally"; returns 200 directly, no redirect), which is the current Shopify CLI page about running an app locally.

I used an AI assistant to find this broken link; the old and new URLs were checked with curl.

Reviewer's guide to testing

Open both URLs: the old one is a 404, the new one is the local development guide.

Things to focus on

  1. README.md: one link.

Checklist

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users (not needed: README link only)
  • Update README.md, if appropriate.
  • Update any relevant pages in /docs, if necessary (not needed)
  • For security fixes, the Disclosure Policy must be followed. (not a security fix)

The "localhost development" link points to
shopify.dev/docs/apps/build/cli-for-apps/development, which now returns
404. Point it at the "Test apps locally" page instead.
@farisbasha

Copy link
Copy Markdown
Author

I have signed the CLA!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant