Skip to content

added verbose error on proxy upstream dialing - #355

Merged
miry merged 3 commits into
Shopify:masterfrom
f-dg:master
Jan 12, 2022
Merged

miry merged 3 commits into
Shopify:masterfrom
f-dg:master

Conversation

@f-dg

@f-dg f-dg commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

Added more verbosity when an error happens during dialing an upstream.
It helped me to find out a reason about what errors were when trying to connect.

@ghost ghost added the cla-needed label Jan 11, 2022
@miry

miry commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

@f-dg Thank you for your contribution. Can you please sign CLA and update CHANGELOG.md?

CLA check: https://github.com/Shopify/toxiproxy/pull/355/checks?check_run_id=4781611074

@miry miry added this to the 2.4.0 milestone Jan 11, 2022
@ghost ghost removed the cla-needed label Jan 11, 2022
@f-dg

f-dg commented Jan 11, 2022

Copy link
Copy Markdown
Contributor Author

@miry Done

Comment thread CHANGELOG.md Outdated
* Verify git tag on release (#347, @miry)
* Fix MacOS 12 tests for go17 with -race flag (#351, @strech)
* Rename `testing/` and `bin/` folders (#354, @strech)
* Added verbose error on proxy upstream dialing

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to mention issue and yourself.

* Added verbose error on proxy upstream dialing (#355, @f-dg)

@miry miry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f-dg Thank you for the contribution and usage. I left small comment about changelog record, everything else is ready.

@miry
miry merged commit 6b0cfad into Shopify:master Jan 12, 2022
@miry

miry commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

@f-dg ❤️

@miry miry added the Toxiproxy label Jan 20, 2022
@miry miry mentioned this pull request Jan 20, 2022
8 tasks done
@neufeldtech

Copy link
Copy Markdown
Contributor

@f-dg Changes have been released as part of https://github.com/Shopify/toxiproxy/releases/tag/v2.4.0. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants