Repository navigation
Fix invalid JSON in /version endpoint response - #538
Conversation
|
I have signed the CLA! |
|
Hi @miry! 👋 This seems like a small but nice fix to have in here. Let me know if I can do anything to expedite this 😊 |
|
cc: @abecevello |
|
This should work, running this playground shows the difference between the two string structures. Once CI passes, I'll also throw an approval on this 👍 |
|
@whatyouhide I've run the tests and it looks like |
|
Ah, yes. Sorry, I didn't even run tests locally cause I don't work in Go and had nothing set up for it. I took the laziest approach 😅 Anyways, I pushed a commit that should fix the test 🤞 |
|
@whatyouhide thanks for the fix. I've merged it and I'll see about doing a release that includes this soon. |
The
/versionendpoint returns invalid JSON, because the\ncharacter at the end of the response is escaped by the backticks. This PR should fix that. I’m no Go expert, so I’m just winging this 🙃