Repository navigation
refactor: map the Jira issue details response in GetIssueRequest - #97
Merged
Merged
Conversation
The request now returns a JiraIssueDetails DTO with the issue, its comments and its status changes, so the TicketProvider no longer parses raw JSON and the request drops its response-dto architecture exemption. Closes #38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetIssueRequestnow maps its own response to a typedJiraIssueDetailsDTO (issue, comments, status changes), soTicketProvider::fetchTicketDetails()no longer parses raw JSON and the request loses itsresponse-dtoarchitecture exemption.Closes #38
Decisions
JiraIssue,JiraCommentandJiraChangelogEntry: their fields already matched the response, so the only new class is theJiraIssueDetailswrapper.fetchTicketDetails, sotests/Integration/Jira/TicketProviderTest.phpwas committed before the refactor to pin the old output (rendered comments, blank comment dropped, only status changelog items,historyId-itemIndexids, 404 → null).tests/Architecture/ArchitectureTest.phpfrom the issue no longer exists. The exemption was the@arch-ignore response-dtomarker on the request, which is now removed.createDtoFromResponse(), the wayGetIssuesRequestdoes it, not in private helpers.TicketProvider, before->dto(), so a 404 still returns null.Review
A code-review agent found no blockers. Two optional nits are left out on purpose:
JiraIssuerepeats code fromGetIssuesRequest. Nothing on our DTOs shares construction like this yet.trim()throws on it.Docs
Nothing in the domain docs (#96) changes.
Verification
Full Pest suite green, PHPStan 0 errors, Pint clean.