Repository navigation
feat: public budget share page and share link actions - #33
Open
claude-for-timatic[bot] wants to merge 2 commits into
Open
claude-for-timatic[bot] wants to merge 2 commits into
claude-for-timatic[bot] wants to merge 2 commits into
Conversation
Users who can update budgets create, regenerate and revoke the link from the budget detail page. The link opens the budget detail page without a login: no entries, prices, change number or people. Closes #14
- Render the budget description as text instead of html. - Tell the user the description is visible through the link. - Show the invalid-link state when periods or the chart fail to load. - Load the app's data once the first internal page is reached. - Disable creating a link for budgets hidden from the customer. - Keep the share token out of the console and search engines. Refs #14
tomasvanrijsse
self-requested a review
November 9, 2026 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14
Needs Timatic/timatic-backend#100.
What it does
/shared-budgets/:id:#token) and sent asX-Share-Tokeninstead of the bearer.BudgetDetailwith anisPublicprop) without these: entries, prices and rates, change number, account manager, supervisor, allowed users, and all actions.noindex.budgets.update):Decisions
whitespace-pre-line) instead ofv-html. That closes an XSS that a public page would expose to customers.BaseModalshows Laravel'smessagewhen an error has no JSON:APIerrors(the 422 text).budgets.update, not the archived-aware edit check, because the backend keeps archived budgets readable.Review
A code, security and usability review found no blockers. Applied:
Verification
nuxt buildpasses. Not tried in a browser. ESLint doesn't run: ESLint 10 doesn't read the repo's existing.eslintrc.js, which predates this PR.