Skip to content

Redis scheduler store: RESP3 cursor pages, the retention default, an unreadable row skipped, a wait for the new index - #2803

Merged
amankrx merged 6 commits into
TraceMachina:mainfrom
amankrx:pr/redis-record-hygiene
Sep 28, 2026
Merged

amankrx merged 6 commits into
TraceMachina:mainfrom
amankrx:pr/redis-record-hygiene

Conversation

@amankrx

@amankrx amankrx commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

What and why

Four small fixes to the Redis-backed scheduler store, each found on a test cluster. A cursor page after the first came back in the RESP3 shape the first page already parses, and failed. The Redis backend never applied the 60 s retention default, so completed records lived until evicted. The queue listing ended at a record it could not read instead of skipping it. And a freshly created search index was read before its initial scan finished, so the first listing after a restart missed rows.

How was this verified?

Pinned command sequences in redis_store_test.rs cover the RESP3 page shape and the FT.INFO wait after FT.CREATE, and fail on the old code. The listing is tested with a fault-injecting database: a row the store cannot decode and a record that cannot be read are each left out and the rest listed, in both the queued and the all-operations listings, the sweep retires the rest, and a read failing because the store is unreachable is reported rather than skipped; those tests fail without the change. The retention default is one helper shared by both backends, with a test. On a test cluster, completed records now carry a TTL, a restart's first pass read the whole queue, and a corrupted record no longer ended the listing. The runbook gains the one-off EXPIRE pass for records written before this.

Risk

Low. Completed records expire after 60 s on Redis as they always did in memory; a deployment relying on them staying longer should set retain_completed_for_s. The index wait adds one FT.INFO round trip per index creation.

AI assistance

An agent drafted the change and I reviewed every line.


This change is Reviewable

@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Sep 28, 2026 8:23pm UTC
nativelink-aidm Ready Ready Preview Sep 28, 2026 8:23pm UTC

Request Review

…arses

(cherry picked from commit 1b85fc8c97a3346e4e792795f707bcdd4ef1d275)
… records expire

(cherry picked from commit 183a533c2e565f462f866b8f160c0e55a3e1b19a)
(cherry picked from commit ceb68a3aebda279802384c65e604961675b9e107)
(cherry picked from commit 955d1fbcf6212d78862d76da77b3cbadef6920f1)

@MarcusSorealheis MarcusSorealheis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for fixing

@MarcusSorealheis MarcusSorealheis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amankrx
amankrx merged commit 5ef7a83 into TraceMachina:main Sep 28, 2026
35 checks passed

This branch was successfully deployed

2 active deployments
Preview – nativelink — b617dba1 Deployed Sep 28, 2026 by vercel[bot]
Preview – nativelink-aidm — b617dba1 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants