Repository navigation
Give the oversized-upload store tests the 30 s deadline the third already has - #2818
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
palfrey
approved these changes
Sep 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Two store tests push about 10 MiB through a fake gRPC server with a 5 second RPC deadline. Under ASan on a loaded runner the transfer alone can take longer than that, and the job fails with
DeadlineExceeded. The deadline is headroom for the transfer, not what the tests check, so both now get the 30 seconds the neighbouring oversized-upload test already uses.How was this verified?
The store test file passes locally. The same job passed on main with the same tests, so this only removes the timing margin that made it a coin flip.
Risk
None to shipped code; two test constants change.
AI assistance
An agent drafted the change and I reviewed every line.
This change is