Skip to content

Give the oversized-upload store tests the 30 s deadline the third already has - #2818

Merged
amankrx merged 2 commits into
TraceMachina:mainfrom
amankrx:fix/grpc-store-test-deadline
Sep 29, 2026
Merged

amankrx merged 2 commits into
TraceMachina:mainfrom
amankrx:fix/grpc-store-test-deadline

Conversation

@amankrx

@amankrx amankrx commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

What and why

Two store tests push about 10 MiB through a fake gRPC server with a 5 second RPC deadline. Under ASan on a loaded runner the transfer alone can take longer than that, and the job fails with DeadlineExceeded. The deadline is headroom for the transfer, not what the tests check, so both now get the 30 seconds the neighbouring oversized-upload test already uses.

How was this verified?

The store test file passes locally. The same job passed on main with the same tests, so this only removes the timing margin that made it a coin flip.

Risk

None to shipped code; two test constants change.

AI assistance

An agent drafted the change and I reviewed every line.


This change is Reviewable

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Sep 29, 2026 3:46pm UTC
nativelink-aidm Ready Ready Preview Sep 29, 2026 3:46pm UTC

Request Review

@amankrx
amankrx merged commit 3ff63f1 into TraceMachina:main Sep 29, 2026
53 of 60 checks passed

This branch was successfully deployed

2 active deployments
Preview – nativelink — 580043a4 Deployed Sep 29, 2026 by vercel[bot]
Preview – nativelink-aidm — 580043a4 Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants